Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2779233004: Add runtime permission to install packages (Closed)

Created:
3 years, 8 months ago by David Trainor- moved to gerrit
Modified:
3 years, 8 months ago
Reviewers:
Ted C, amineer
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add runtime permission to install packages On Android O we need the REQUEST_INSTALL_PACKAGE to be able to install APKs. Adding the permission to our manifest and adding it to be set by default on developer builds. Has no effect on pre-M builds. BUG=706570 Review-Url: https://codereview.chromium.org/2779233004 Cr-Commit-Position: refs/heads/master@{#460635} Committed: https://chromium.googlesource.com/chromium/src/+/817ab0f404dc89f75187b1a23cd6f5fcc5b93a3a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/android/java/AndroidManifest.xml View 2 chunks +3 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (6 generated)
David Trainor- moved to gerrit
ted ptal. feel free to CC anyone who you think could help me make sure ...
3 years, 8 months ago (2017-03-30 00:16:45 UTC) #2
Ted C
amineer as an FYI lgtm
3 years, 8 months ago (2017-03-30 00:20:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779233004/1
3 years, 8 months ago (2017-03-30 00:51:19 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 03:08:57 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/817ab0f404dc89f75187b1a23cd6...

Powered by Google App Engine
This is Rietveld 408576698