[Sync] Sort protos in proto_visitors.h

[Sync] Sort protos in proto_visitors.h

The issue came up in my previous change: https://codereview.chromium.org/2781863004/diff/20001/components/sync/protocol/proto_visitors.h#newcode863

Sorting was done with a script without manual modifications: http://gpaste/5396105323872256

R=skym@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2779203004
Cr-Commit-Position: refs/heads/master@{#461040}
Committed: https://chromium.googlesource.com/chromium/src/+/1c44aedea445b82f6ac2c983dc60f41f478dbbbc

[pavely, 2017-03-30 01:20:10]

Description was changed from

==========
[Sync] Sort protos in proto_visitors.h

R=pnoland@chromium.org
BUG=
==========

to

==========
[Sync] Sort protos in proto_visitors.h

The issue came up in my previous change:
https://codereview.chromium.org/2781863004/diff/20001/components/sync/protoco...

Sorting was done with a script without manual modifications:
http://gpaste/5396105323872256

R=skym@chromium.org
BUG=
==========

[pavely, 2017-03-30 01:20:10]

pavely@chromium.org changed reviewers:
+ skym@chromium.org
- pnoland@chromium.org

[skym, 2017-03-31 00:08:11]

lgtm

https://codereview.chromium.org/2779203004/diff/1/components/sync/protocol/pr...
File components/sync/protocol/proto_visitors.h (right):

https://codereview.chromium.org/2779203004/diff/1/components/sync/protocol/pr...
components/sync/protocol/proto_visitors.h:356: // TODO(akalin): Shouldn't blob
be of type bytes instead of string?
Is this TODO still relevant?

[pavely, 2017-03-31 04:06:46]

https://codereview.chromium.org/2779203004/diff/1/components/sync/protocol/pr...
File components/sync/protocol/proto_visitors.h (right):

https://codereview.chromium.org/2779203004/diff/1/components/sync/protocol/pr...
components/sync/protocol/proto_visitors.h:356: // TODO(akalin): Shouldn't blob
be of type bytes instead of string?
On 2017/03/31 00:08:11, skym wrote:
> Is this TODO still relevant?

blob is still declared as string in encryption.proto. It doesn't cause any
issues on the client side and it won't make any difference if it is turned into
bytes. The difference might show up on server side as string and bytes fields
are mapped into different types with different interfaces (String vs.
ByteString). I'd rather test that server still compiles with the change, but
don't want to do it for this particular change.

[pavely, 2017-03-31 04:06:53]

The CQ bit was checked by pavely@chromium.org

[commit-bot: I haz the power, 2017-03-31 04:07:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 04:55:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490933213511900, "parent_rev":
"abb90e0c1a294e54530ba68db99076eafefbfa9e", "commit_rev":
"1c44aedea445b82f6ac2c983dc60f41f478dbbbc"}

[commit-bot: I haz the power, 2017-03-31 04:56:45]

Description was changed from

==========
[Sync] Sort protos in proto_visitors.h

The issue came up in my previous change:
https://codereview.chromium.org/2781863004/diff/20001/components/sync/protoco...

Sorting was done with a script without manual modifications:
http://gpaste/5396105323872256

R=skym@chromium.org
BUG=
==========

to

==========
[Sync] Sort protos in proto_visitors.h

The issue came up in my previous change:
https://codereview.chromium.org/2781863004/diff/20001/components/sync/protoco...

Sorting was done with a script without manual modifications:
http://gpaste/5396105323872256

R=skym@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2779203004
Cr-Commit-Position: refs/heads/master@{#461040}
Committed:
https://chromium.googlesource.com/chromium/src/+/1c44aedea445b82f6ac2c983dc60...
==========

[commit-bot: I haz the power, 2017-03-31 04:56:46]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1c44aedea445b82f6ac2c983dc60...