Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2825)

Unified Diff: build/secondary/testing/gtest/BUILD.gn

Issue 2779193002: Roll googletest to 1.8.0. (Closed)
Patch Set: Rebase + trial of GN tweaks needed for v8. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/secondary/testing/gtest/BUILD.gn
diff --git a/build/secondary/testing/gtest/BUILD.gn b/build/secondary/testing/gtest/BUILD.gn
index 649f5c559db4054f6815b77432f39e04e0ca769e..637048cc42d9eae688b1e5d6331d08b65d54f4fa 100644
--- a/build/secondary/testing/gtest/BUILD.gn
+++ b/build/secondary/testing/gtest/BUILD.gn
@@ -2,6 +2,13 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+# Chromium's GN configuration for gtest now lives at testing/gtest/BUILD.gn.
+#
+# This configuration is left in the tree because it is pulled by V8 and PDFium,
+# and will be removed as soon as the projects switch off of it.
Nico 2017/04/28 20:56:23 I think we should either just remove this or make
pwnall 2017/04/29 00:16:26 If we remove build/secondary, v8 and pdifum can't
Nico 2017/05/01 17:52:54 Ok, let's do this separately. This kind of raises
+#
+# Details at http://crbug.com/630705 and http://crrev.com/2779193002
+
import("//build_overrides/gtest.gni")
config("gtest_config") {

Powered by Google App Engine
This is Rietveld 408576698