Roll googletest to 1.8.0.

build/secondary/testing/gtest/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+# Chromium's GN configuration for gtest now lives at testing/gtest/BUILD.gn.
+#
+# This configuration is left in the tree because it is pulled by V8 and PDFium,
+# and will be removed as soon as the projects switch off of it.

[Nico, 2017/04/28 20:56:23]

I think we should either just remove this or make it forward to the new
locations. v8 and pdfium can then merge this change the next time they pull
chromium. Having this here might confuse gn and it won't pick up the new
BUILD.gn.

[pwnall, 2017/04/29 00:16:26]

If we remove build/secondary, v8 and pdifum can't merge Chromium until they land
a variation of this Google Test migration CL. I was afraid that hard consistency
would be a lot more difficult to achieve than eventual consistency.

FWIW, according to the bots and local results, GN seems to use build/secondary
as a fallback. So, while humans and other tools might get confused, GN doesn't
seem to.

I don't really know how often V8 or PDFium update build/, so I don't know if
this is an actual problem. Do you still think we should remove build/secondary
in this CL?

[Nico, 2017/05/01 17:52:54]

Ok, let's do this separately.

This kind of raises the question: How are pdfium etc use this at all? They'll
need third_party/googletest/BUILD.gn, so I suppose we'll have to ask infra to
mirror out third_party/googletest to https://chromium.googlesource.com/ and then
those projects will have to deps in both that repo and the actual gtest repo?

+#
+# Details at http://crbug.com/630705 and http://crrev.com/2779193002
+
 import("//build_overrides/gtest.gni")
 
 config("gtest_config") {
   visibility = [
     ":*",
     "//testing/gmock:*",  # gmock also shares this config.
   ]
 
   defines = [
     # In order to allow regex matches in gtest to be shared between Windows
@@ skipping 62 matching lines @@
     sources += [
       "../multiprocess_func_list.cc",
       "../multiprocess_func_list.h",
     ]
   }
 
   if (gtest_include_platform_test) {
     sources += [ "../platform_test.h" ]
   }
 
   if ((is_mac || is_ios) && gtest_include_objc_support) {

[Nico, 2017/04/28 20:56:23]

I think this bit is missing from the new BUILD.gn file and it's probably needed.
../*test_mac.* should probably move to third_party/gtest too.

[pwnall, 2017/04/29 00:16:26]

The Mac bits are in testing/gtest/BUILD.gn --
https://codereview.chromium.org/2852613002/diff/40001/testing/gtest/BUILD.gn

I thought it'd be desirable to have third_party/googletest match upstream as
much as possible. I think I was wrong, because we're not shy about adding files
to other third_party projects, like leveldb. Moving *test_mac* to googletest
would let me remove a hack that I have to introduce now, so I really like it.
The hack is at http://crrev.com/2852613002#msg11

OTOH, gtest_mac.h is #included in a lot of places. Would you be OK with moving
it in a separate CL? -- https://cs.chromium.org/search/?q="testing/gtest_mac.h"

[Nico, 2017/05/01 17:52:54]

I think in general we try to keep third-party libs unchanged, leveldb is a bit
of an exception (though there are others). But since this isn't really changing
gtest but just adding a file to it, maybe it's better. (The plan was originally
to add gtest_mac to upstream gtest, but upstream didn't like it.)
Yes, let's wait with that if it's possible to fix the problem that caused the
revert without doing it. I thought maybe it's needed to fix that link error. (If
we have to move it, I'd suggest to add a forwarding header for it too, like for
all the other files in regular gtest.)

     if (is_ios) {
       set_sources_assignment_filter([])
     }
     sources += [
       "../gtest_mac.h",
       "../gtest_mac.mm",
     ]
     if (gtest_include_platform_test) {
       sources += [ "../platform_test_mac.mm" ]
     }
@@ skipping 23 matching lines @@
 
 source_set("gtest_main") {
   testonly = true
   sources = [
     "src/gtest_main.cc",
   ]
   deps = [
     ":gtest",
   ]
 }