Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 2779143002: [inspector] added test for StepOut at return postion from async function (Closed)

Created:
3 years, 8 months ago by kozy
Modified:
3 years, 8 months ago
Reviewers:
dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] added test for StepOut at return postion from async function Should be fixed. BUG=v8:6161 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2779143002 Cr-Commit-Position: refs/heads/master@{#44209} Committed: https://chromium.googlesource.com/v8/v8/+/b6bbf6821b156ce84bb9c8a6df8f8471e50b4e7c

Patch Set 1 #

Patch Set 2 : removed printfs #

Patch Set 3 : better test description #

Patch Set 4 : better expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -0 lines) Patch
A test/inspector/debugger/step-out-async-await.js View 1 2 1 chunk +72 lines, -0 lines 0 comments Download
A test/inspector/debugger/step-out-async-await-expected.txt View 1 2 3 1 chunk +67 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
kozy
Dmitry, please take a look.
3 years, 8 months ago (2017-03-28 20:06:23 UTC) #2
dgozman
lgtm
3 years, 8 months ago (2017-03-28 20:36:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779143002/60001
3 years, 8 months ago (2017-03-28 20:49:50 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 21:14:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/b6bbf6821b156ce84bb9c8a6df8f8471e50...

Powered by Google App Engine
This is Rietveld 408576698