Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2779113006: [Android] 'Open in browser' in context menu for CCT does not work for image. (Closed)

Created:
3 years, 8 months ago by ltian
Modified:
3 years, 8 months ago
Reviewers:
gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] 'Open in browser' in context menu for CCT does not work for image. When the default browser is not set, the 'Open in browser' option in the context menu for CCT does not work for image and video link. This is because for image and video, the linkUrl of the ContextMenuParams is null. It is a same problem as the bug here: https://bugs.chromium.org/p/chromium/issues/detail?id=696417. And to fix it, follow this CL: https://codereview.chromium.org/2739723004/ that checks the type of link first then passes different urls for different types of link. BUG=706209 Review-Url: https://codereview.chromium.org/2779113006 Cr-Commit-Position: refs/heads/master@{#460505} Committed: https://chromium.googlesource.com/chromium/src/+/83bb552f1111fc669d47cb8070f647a8e2caf1d7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
ltian
dfalcantara@chromium.org: Can you take a look for this CL? It has the similar problem as ...
3 years, 8 months ago (2017-03-29 19:01:53 UTC) #2
gone
lgtm
3 years, 8 months ago (2017-03-29 19:04:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779113006/1
3 years, 8 months ago (2017-03-29 19:05:39 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 20:01:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/83bb552f1111fc669d47cb8070f6...

Powered by Google App Engine
This is Rietveld 408576698