Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2779103002: Convert context property tests to new Audit. (Closed)

Created:
3 years, 8 months ago by Raymond Toy
Modified:
3 years, 8 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert context property tests to new Audit. Manually convert these tests to use new Audit instead of old. BUG=704967 TESTS=AudioContext/audiocontext-properties.html BaseAudioContext/baseaudiocontext-properties.html OfflineAudioContext/offlineaudiocontext-properties.html Review-Url: https://codereview.chromium.org/2779103002 Cr-Commit-Position: refs/heads/master@{#461884} Committed: https://chromium.googlesource.com/chromium/src/+/0aef4e70e7c0cf49e6546a2b04d48d42009e7a46

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -33 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-properties.html View 2 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/BaseAudioContext/baseaudiocontext-properties.html View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-properties.html View 2 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js View 1 1 chunk +7 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Raymond Toy
PTAL
3 years, 8 months ago (2017-04-04 20:54:34 UTC) #2
hongchan
lgtm https://codereview.chromium.org/2779103002/diff/1/third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js File third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js (right): https://codereview.chromium.org/2779103002/diff/1/third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js#newcode91 third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js:91: // TODO(hongchan): replace the Should assertion when the ...
3 years, 8 months ago (2017-04-04 21:18:17 UTC) #3
Raymond Toy
https://codereview.chromium.org/2779103002/diff/1/third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js File third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js (right): https://codereview.chromium.org/2779103002/diff/1/third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js#newcode91 third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js:91: // TODO(hongchan): replace the Should assertion when the new ...
3 years, 8 months ago (2017-04-04 21:41:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779103002/20001
3 years, 8 months ago (2017-04-04 21:42:21 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 23:11:52 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0aef4e70e7c0cf49e6546a2b04d4...

Powered by Google App Engine
This is Rietveld 408576698