Make content verification see 0-byte files.

Make content verification see 0-byte files.

Currently ContentVerifyJob never sees DoneReading() for (legitimate
or not) 0-byte files. This means 0-byte files (legitimate or corrupted)
never goes through content verification process.
Override URLRequestJob::DoneReading() in URLRequestExtensionJob to
detect the end of 0-byte files so that ContentVerifyJob knows about
these 0-byte files.

Add a test to ensure that URLRequestExtensionJob will see 0-byte files.
ContentVerifyJobUnittest.DeletedAndMissingFiles already makes sure
that 0-byte read will fail content verification.

BUG=703888, 703892
Test=With content verification turned on (e.g. with
--extension-content-verification=enforce_strict flag), install an
extension from webstore and modify a JS content inside that extension
to 0 byte file. Content verification should fail for that extension.
If the extension is part of system policy, the extension will be
reinsalled.

Review-Url: https://codereview.chromium.org/2779083005
Cr-Commit-Position: refs/heads/master@{#460638}
Committed: https://chromium.googlesource.com/chromium/src/+/e83ab9c6c27deb3e96dee4a33a6518c206724d16

[lazyboy, 2017-03-29 17:38:23]

Patchset #2 (id:20001) has been deleted

[lazyboy, 2017-03-29 18:03:14]

Description was changed from

==========
Make content verification see 0-byte files.

Currently ContentVerifyJob never sees DoneReading() for (legitimate
or not) 0-byte files. This means 0-byte files (legitimate or corrupted)
never goes through content verification process.
Override URLRequestJob::DoneReading() in URLRequestExtensionJob to
detect the end of 0-byte files so that ContentVerifyJob knows about
these 0-byte files.

Add tests for these.
BUG=703888,703892
Test=With content verification turned on (e.g. with
--extension-content-verification=enforce_strict flag), install an
extension from webstore and modify a JS content inside that extension
to 0 byte file. Content verification should fail for that extension.
If the extension is part of system policy, the extension will be
reinsalled.
==========

to

==========
Make content verification see 0-byte files.

Currently ContentVerifyJob never sees DoneReading() for (legitimate
or not) 0-byte files. This means 0-byte files (legitimate or corrupted)
never goes through content verification process.
Override URLRequestJob::DoneReading() in URLRequestExtensionJob to
detect the end of 0-byte files so that ContentVerifyJob knows about
these 0-byte files.

Add a test to ensure that URLRequestExtensionJob will see 0-byte files.
ContentVerifyJobUnittest.DeletedAndMissingFiles already makes sure
that 0-byte read will fail content verification.

BUG=703888,703892
Test=With content verification turned on (e.g. with
--extension-content-verification=enforce_strict flag), install an
extension from webstore and modify a JS content inside that extension
to 0 byte file. Content verification should fail for that extension.
If the extension is part of system policy, the extension will be
reinsalled.
==========

[lazyboy, 2017-03-29 18:10:14]

lazyboy@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[lazyboy, 2017-03-29 18:10:14]

Depends on https://codereview.chromium.org/2771953003/, but much easier to read
:)

[Devlin, 2017-03-29 18:29:48]

lgtm

https://codereview.chromium.org/2779083005/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_protocols_unittest.cc (right):

https://codereview.chromium.org/2779083005/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_protocols_unittest.cc:558: const char
kFooJsContents[] = "";  // Empty.
This won't do something silly like write a file with a null terminator byte,
will it?  For paranoid sanity checking, can we file_util::GetFileSize() on it
and ASSERT it's 0?

[lazyboy, 2017-03-29 20:09:59]

https://codereview.chromium.org/2779083005/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_protocols_unittest.cc (right):

https://codereview.chromium.org/2779083005/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_protocols_unittest.cc:558: const char
kFooJsContents[] = "";  // Empty.
On 2017/03/29 18:29:48, Devlin wrote:
> This won't do something silly like write a file with a null terminator byte,
> will it?  For paranoid sanity checking, can we file_util::GetFileSize() on it
> and ASSERT it's 0?

Done.

[lazyboy, 2017-03-30 01:19:10]

The CQ bit was checked by lazyboy@chromium.org

[lazyboy, 2017-03-30 01:19:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2779083005/#ps80001
(title: "sync")

[commit-bot: I haz the power, 2017-03-30 01:20:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 03:18:30]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490836750574850,
"parent_rev": "20f1d3ad8fc29955bc0e1b7a4dcb8e887cb613a3", "commit_rev":
"e83ab9c6c27deb3e96dee4a33a6518c206724d16"}

[commit-bot: I haz the power, 2017-03-30 03:20:08]

Description was changed from

==========
Make content verification see 0-byte files.

Currently ContentVerifyJob never sees DoneReading() for (legitimate
or not) 0-byte files. This means 0-byte files (legitimate or corrupted)
never goes through content verification process.
Override URLRequestJob::DoneReading() in URLRequestExtensionJob to
detect the end of 0-byte files so that ContentVerifyJob knows about
these 0-byte files.

Add a test to ensure that URLRequestExtensionJob will see 0-byte files.
ContentVerifyJobUnittest.DeletedAndMissingFiles already makes sure
that 0-byte read will fail content verification.

BUG=703888,703892
Test=With content verification turned on (e.g. with
--extension-content-verification=enforce_strict flag), install an
extension from webstore and modify a JS content inside that extension
to 0 byte file. Content verification should fail for that extension.
If the extension is part of system policy, the extension will be
reinsalled.
==========

to

==========
Make content verification see 0-byte files.

Currently ContentVerifyJob never sees DoneReading() for (legitimate
or not) 0-byte files. This means 0-byte files (legitimate or corrupted)
never goes through content verification process.
Override URLRequestJob::DoneReading() in URLRequestExtensionJob to
detect the end of 0-byte files so that ContentVerifyJob knows about
these 0-byte files.

Add a test to ensure that URLRequestExtensionJob will see 0-byte files.
ContentVerifyJobUnittest.DeletedAndMissingFiles already makes sure
that 0-byte read will fail content verification.

BUG=703888,703892
Test=With content verification turned on (e.g. with
--extension-content-verification=enforce_strict flag), install an
extension from webstore and modify a JS content inside that extension
to 0 byte file. Content verification should fail for that extension.
If the extension is part of system policy, the extension will be
reinsalled.

Review-Url: https://codereview.chromium.org/2779083005
Cr-Commit-Position: refs/heads/master@{#460638}
Committed:
https://chromium.googlesource.com/chromium/src/+/e83ab9c6c27deb3e96dee4a33a65...
==========

[commit-bot: I haz the power, 2017-03-30 03:20:09]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/e83ab9c6c27deb3e96dee4a33a65...