Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3039)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2779083003: Add additional metrics for main intent behaviors. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
index 9a685eef10f3dac2f34afa42870833ae0b82944b..6b57ebb41b09ff3a9c63eb48646ec59383c02235 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
@@ -761,11 +761,13 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
normalTabModel.setIndex(
TabModelUtils.getTabIndexById(normalTabModel, tab.getId()),
TabSelectionType.FROM_USER);
+ RecordUserAction.record("MobileStartup.MainIntent.NTPCreatedDueToInactivity");
return true;
}
}
getTabCreator(false).launchUrl(UrlConstants.NTP_URL, TabLaunchType.FROM_EXTERNAL_APP);
+ RecordUserAction.record("MobileStartup.MainIntent.NTPCreatedDueToInactivity");
Ilya Sherman 2017/03/28 18:19:54 nit: Could you move this to be above the for loop,
Ted C 2017/03/28 20:32:22 There is a return true at the top of the if check
return true;
}

Powered by Google App Engine
This is Rietveld 408576698