Add additional metrics for main intent behaviors.

Add additional metrics for main intent behaviors.

BUG=705773
Review-Url: https://codereview.chromium.org/2779083003
Cr-Commit-Position: refs/heads/master@{#460262}
Committed: https://chromium.googlesource.com/chromium/src/+/3035cbe83b6bf591b7d955242b73ad7df5a3e3ff

[Ted C, 2017-03-28 16:44:51]

tedchoc@chromium.org changed reviewers:
+ mariakhomenko@chromium.org

[Ted C, 2017-03-28 16:44:52]

PTAL

[Maria, 2017-03-28 17:45:23]

lgtm

[Ted C, 2017-03-28 17:53:15]

tedchoc@chromium.org changed reviewers:
+ isherman@chromium.org

[Ted C, 2017-03-28 17:53:16]

+isherman for actions.xml

[Ilya Sherman, 2017-03-28 18:19:54]

Are you sure that you want to use actions rather than histograms?  Histograms
seem like they'd be more convenient, but if you prefer actions for analysis,
then LGTM.

https://codereview.chromium.org/2779083003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
(right):

https://codereview.chromium.org/2779083003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java:770:
RecordUserAction.record("MobileStartup.MainIntent.NTPCreatedDueToInactivity");
nit: Could you move this to be above the for loop, so that the line isn't
repeated?  It looks like it's guaranteed to happen on all code paths, right?

https://codereview.chromium.org/2779083003/diff/1/tools/metrics/actions/actio...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/2779083003/diff/1/tools/metrics/actions/actio...
tools/metrics/actions/actions.xml:10375: An ACTION_MAIN intent was received by
Chrome and a NTP was created due to
nit: s/a NTP/an NTP

https://codereview.chromium.org/2779083003/diff/1/tools/metrics/actions/actio...
tools/metrics/actions/actions.xml:10416: Chrome for 6 hours.
nit: but fewer than 12 hours (and please document the other metrics in this way
as well)

[Ted C, 2017-03-28 20:32:23]

We are specifically looking for user actions to help understand fine grain
sequencing better.

https://codereview.chromium.org/2779083003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
(right):

https://codereview.chromium.org/2779083003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java:770:
RecordUserAction.record("MobileStartup.MainIntent.NTPCreatedDueToInactivity");
On 2017/03/28 18:19:54, Ilya Sherman wrote:
> nit: Could you move this to be above the for loop, so that the line isn't
> repeated?  It looks like it's guaranteed to happen on all code paths, right?

There is a return true at the top of the if check above that return without
logging intentionally.  I didn't like the look of this either, so I uploaded a
version that only logs it once with a bit of tweak of the ordering.

https://codereview.chromium.org/2779083003/diff/1/tools/metrics/actions/actio...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/2779083003/diff/1/tools/metrics/actions/actio...
tools/metrics/actions/actions.xml:10375: An ACTION_MAIN intent was received by
Chrome and a NTP was created due to
On 2017/03/28 18:19:54, Ilya Sherman wrote:
> nit: s/a NTP/an NTP

Done.

https://codereview.chromium.org/2779083003/diff/1/tools/metrics/actions/actio...
tools/metrics/actions/actions.xml:10416: Chrome for 6 hours.
On 2017/03/28 18:19:54, Ilya Sherman wrote:
> nit: but fewer than 12 hours (and please document the other metrics in this
way
> as well)

Done.

[Ted C, 2017-03-28 23:06:05]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2017-03-28 23:06:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, mariakhomenko@chromium.org
Link to the patchset: https://codereview.chromium.org/2779083003/#ps20001
(title: "Address isherman@ comments")

[commit-bot: I haz the power, 2017-03-28 23:06:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 01:09:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 01:09:12]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)

[Ted C, 2017-03-29 02:00:10]

The CQ bit was checked by tedchoc@chromium.org

[commit-bot: I haz the power, 2017-03-29 02:01:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 02:24:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490752810913300,
"parent_rev": "d9e13bfe15b276e7801a984014364d26e1d61328", "commit_rev":
"3035cbe83b6bf591b7d955242b73ad7df5a3e3ff"}

[commit-bot: I haz the power, 2017-03-29 02:25:01]

Description was changed from

==========
Add additional metrics for main intent behaviors.

BUG=705773
==========

to

==========
Add additional metrics for main intent behaviors.

BUG=705773

Review-Url: https://codereview.chromium.org/2779083003
Cr-Commit-Position: refs/heads/master@{#460262}
Committed:
https://chromium.googlesource.com/chromium/src/+/3035cbe83b6bf591b7d955242b73...
==========

[commit-bot: I haz the power, 2017-03-29 02:25:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3035cbe83b6bf591b7d955242b73...