Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2779033003: [regexp] Stage named captures (Closed)

Created:
3 years, 8 months ago by jgruber
Modified:
3 years, 8 months ago
Reviewers:
Yang, adamk
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Stage named captures BUG=v8:5437 Review-Url: https://codereview.chromium.org/2779033003 Cr-Commit-Position: refs/heads/master@{#44331} Committed: https://chromium.googlesource.com/v8/v8/+/3b716a08044da1073240cd287f35c8517fcf392f

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase and address comments #

Patch Set 3 : Remove move_object_start implication as well now that it's shipped #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M src/flag-definitions.h View 1 2 3 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 27 (17 generated)
jgruber
Adam, PTAL. Design doc: https://docs.google.com/document/d/1IpE1HK66uAibbZ8qhlxEQtwdxKftWUN9oJsV8t1S7so/edit?pli=1#
3 years, 8 months ago (2017-03-29 08:21:01 UTC) #6
Yang
On 2017/03/29 08:21:01, jgruber wrote: > Adam, PTAL. Design doc: > https://docs.google.com/document/d/1IpE1HK66uAibbZ8qhlxEQtwdxKftWUN9oJsV8t1S7so/edit?pli=1 LGTM. Please wait ...
3 years, 8 months ago (2017-03-29 08:31:06 UTC) #7
adamk
lgtm I guess this doesn't go on our Q2 OKRs then :) https://codereview.chromium.org/2779033003/diff/1/src/flag-definitions.h File src/flag-definitions.h ...
3 years, 8 months ago (2017-03-29 17:26:50 UTC) #8
jgruber
On 2017/03/29 17:26:50, adamk wrote: > lgtm > > I guess this doesn't go on ...
3 years, 8 months ago (2017-03-30 06:47:04 UTC) #9
jgruber
On 2017/03/30 06:47:04, jgruber wrote: > On 2017/03/29 17:26:50, adamk wrote: > > lgtm > ...
3 years, 8 months ago (2017-04-03 08:14:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779033003/1
3 years, 8 months ago (2017-04-03 08:15:12 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/16024)
3 years, 8 months ago (2017-04-03 08:16:42 UTC) #14
jgruber
https://codereview.chromium.org/2779033003/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/2779033003/diff/1/src/flag-definitions.h#newcode198 src/flag-definitions.h:198: DEFINE_IMPLICATION(es_staging, harmony_regexp_named_captures) On 2017/03/29 17:26:49, adamk wrote: > This ...
3 years, 8 months ago (2017-04-03 08:25:20 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779033003/40001
3 years, 8 months ago (2017-04-03 09:35:03 UTC) #24
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 09:37:24 UTC) #27
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/3b716a08044da1073240cd287f35c8517fc...

Powered by Google App Engine
This is Rietveld 408576698