Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1780)

Unified Diff: base/posix/unix_domain_socket_linux.cc

Issue 2779033002: Move CreateSocketPair to header file (Closed)
Patch Set: Add BASE_EXPORT Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/posix/unix_domain_socket_linux.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/posix/unix_domain_socket_linux.cc
diff --git a/base/posix/unix_domain_socket_linux.cc b/base/posix/unix_domain_socket_linux.cc
index 8b3094eedfc8305bc1bd13cf9f9e45b41274ed8f..e85732e9d5e8b9b4a0acbdf64e2e80931cbab100 100644
--- a/base/posix/unix_domain_socket_linux.cc
+++ b/base/posix/unix_domain_socket_linux.cc
@@ -29,7 +29,7 @@ const size_t UnixDomainSocket::kMaxFileDescriptors = 16;
// Creates a connected pair of UNIX-domain SOCK_SEQPACKET sockets, and passes
Luis Héctor Chávez 2017/04/05 14:55:44 nit: You already have documentation in the .h. Thi
shunhsingou 2017/04/06 03:16:35 Done.
// ownership of the newly allocated file descriptors to |one| and |two|.
// Returns true on success.
-static bool CreateSocketPair(ScopedFD* one, ScopedFD* two) {
+bool CreateSocketPair(ScopedFD* one, ScopedFD* two) {
int raw_socks[2];
if (socketpair(AF_UNIX, SOCK_SEQPACKET, 0, raw_socks) == -1)
return false;
« no previous file with comments | « base/posix/unix_domain_socket_linux.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698