Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2779013002: Revert of PaymentRequest: Introduce PaymentDetailsInit and PaymentDetailsUpdate. (Closed)

Created:
3 years, 8 months ago by kolos1
Modified:
3 years, 8 months ago
CC:
Aaron Boodman, abarth-chromium, blink-reviews, chromium-reviews, darin (slow to review), darin-cc_chromium.org, gogerald+paymentswatch_chromium.org, jam, mahmadi+paymentswatch_chromium.org, qsr+mojo_chromium.org, rwlbuis, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of PaymentRequest: Introduce PaymentDetailsInit and PaymentDetailsUpdate. (patchset #10 id:180001 of https://codereview.chromium.org/2748093003/ ) Reason for revert: This CL broke compilation on Android and Mac. Original issue's description: > PaymentRequest: Introduce PaymentDetailsInit and PaymentDetailsUpdate. > > The current implementation uses PaymentDetails structure when creating > PaymentRequest object and calling updateWith(). But some parameters like error > are only allowed in the updateWith(). If developer tries to use error parameter > when creating PaymentRequest, then throws exception. So, to solve the problem > in the latest spec[1][2], common parts are combined and each different parts > are separated into PaymentDetailsInit and PaymentDetailsUpdate. > > This change only affects input dictionaries and doesn't break existing behavior. > Therefore, we don't need a intent to implement and ship. > > [1] https://w3c.github.io/browser-payment-api/#paymentdetailsinit-dictionary > [2] https://w3c.github.io/browser-payment-api/#paymentdetailsupdate-dictionary > > BUG=704166 > > Review-Url: https://codereview.chromium.org/2748093003 > Cr-Commit-Position: refs/heads/master@{#460053} > Committed: https://chromium.googlesource.com/chromium/src/+/aec033c55fbc09dade60bc543373deb86c517b1b TBR=tkent@chromium.org,foolip@chromium.org,haraken@chromium.org,rouslan@chromium.org,tsepez@chromium.org,jinho.bang@samsung.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=704166 Review-Url: https://codereview.chromium.org/2779013002 Cr-Commit-Position: refs/heads/master@{#460055} Committed: https://chromium.googlesource.com/chromium/src/+/debb70fbd588bf22ae28d686e705ef27a3c123a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -307 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 2 chunks +9 lines, -21 lines 0 comments Download
M components/payments/content/payment_details_validation.cc View 2 chunks +12 lines, -9 lines 0 comments Download
M components/payments/content/payment_request.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/payments/content/payment_request.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/payments/payment-request-interface.html View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/AbortTest.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/CanMakePaymentTest.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/CompleteTest.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/OnPaymentResponseTest.cpp View 24 chunks +24 lines, -24 lines 0 comments Download
A third_party/WebKit/Source/modules/payments/PaymentDetails.idl View 1 chunk +13 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/modules/payments/PaymentDetailsBase.idl View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/Source/modules/payments/PaymentDetailsInit.idl View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/Source/modules/payments/PaymentDetailsUpdate.idl View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 10 chunks +35 lines, -62 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp View 31 chunks +48 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentTestHelper.h View 2 chunks +3 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp View 2 chunks +42 lines, -72 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kolos1
Created Revert of PaymentRequest: Introduce PaymentDetailsInit and PaymentDetailsUpdate.
3 years, 8 months ago (2017-03-28 10:33:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779013002/1
3 years, 8 months ago (2017-03-28 10:33:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/debb70fbd588bf22ae28d686e705ef27a3c123a5
3 years, 8 months ago (2017-03-28 10:35:26 UTC) #6
tkent
3 years, 8 months ago (2017-03-29 00:48:59 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698