Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 2778983005: Allow the app banner installability check to run on page load. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_manager_android.cc
diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc
index a6d0f74cde0760acc9a47f841344ba24f87639af..e32a81e9c9da6b59ffac27d04dae3ca26f3c50e2 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.cc
+++ b/chrome/browser/android/banners/app_banner_manager_android.cc
@@ -85,7 +85,18 @@ AppBannerManagerAndroid::GetJavaBannerManager() const {
bool AppBannerManagerAndroid::IsActiveForTesting(
JNIEnv* env,
const JavaParamRef<jobject>& obj) {
- return is_active();
+ return IsActive();
+}
+
+void AppBannerManagerAndroid::RecordMenuOpen(JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
+ manager()->RecordMenuOpenHistogram();
+}
+
+void AppBannerManagerAndroid::RecordMenuItemAddToHomescreen(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
+ manager()->RecordMenuItemAddToHomescreenHistogram();
}
bool AppBannerManagerAndroid::OnAppDetailsRetrieved(
@@ -211,7 +222,7 @@ void AppBannerManagerAndroid::OnAppIconFetched(const SkBitmap& bitmap) {
Stop();
}
- if (!is_active())
+ if (!IsActive())
return;
primary_icon_.reset(new SkBitmap(bitmap));

Powered by Google App Engine
This is Rietveld 408576698