Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 2778983005: Allow the app banner installability check to run on page load. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/banners/app_banner_manager_android.h" 5 #include "chrome/browser/android/banners/app_banner_manager_android.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/android/jni_android.h" 10 #include "base/android/jni_android.h"
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 } 78 }
79 79
80 const base::android::ScopedJavaGlobalRef<jobject>& 80 const base::android::ScopedJavaGlobalRef<jobject>&
81 AppBannerManagerAndroid::GetJavaBannerManager() const { 81 AppBannerManagerAndroid::GetJavaBannerManager() const {
82 return java_banner_manager_; 82 return java_banner_manager_;
83 } 83 }
84 84
85 bool AppBannerManagerAndroid::IsActiveForTesting( 85 bool AppBannerManagerAndroid::IsActiveForTesting(
86 JNIEnv* env, 86 JNIEnv* env,
87 const JavaParamRef<jobject>& obj) { 87 const JavaParamRef<jobject>& obj) {
88 return is_active(); 88 return IsActive();
89 }
90
91 void AppBannerManagerAndroid::RecordMenuOpen(JNIEnv* env,
92 const JavaParamRef<jobject>& obj) {
93 manager()->RecordMenuOpenHistogram();
94 }
95
96 void AppBannerManagerAndroid::RecordMenuItemAddToHomescreen(
97 JNIEnv* env,
98 const JavaParamRef<jobject>& obj) {
99 manager()->RecordMenuItemAddToHomescreenHistogram();
89 } 100 }
90 101
91 bool AppBannerManagerAndroid::OnAppDetailsRetrieved( 102 bool AppBannerManagerAndroid::OnAppDetailsRetrieved(
92 JNIEnv* env, 103 JNIEnv* env,
93 const JavaParamRef<jobject>& obj, 104 const JavaParamRef<jobject>& obj,
94 const JavaParamRef<jobject>& japp_data, 105 const JavaParamRef<jobject>& japp_data,
95 const JavaParamRef<jstring>& japp_title, 106 const JavaParamRef<jstring>& japp_title,
96 const JavaParamRef<jstring>& japp_package, 107 const JavaParamRef<jstring>& japp_package,
97 const JavaParamRef<jstring>& jicon_url) { 108 const JavaParamRef<jstring>& jicon_url) {
98 native_app_data_.Reset(japp_data); 109 native_app_data_.Reset(japp_data);
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 215
205 AppBannerManager::OnDidPerformInstallableCheck(data); 216 AppBannerManager::OnDidPerformInstallableCheck(data);
206 } 217 }
207 218
208 void AppBannerManagerAndroid::OnAppIconFetched(const SkBitmap& bitmap) { 219 void AppBannerManagerAndroid::OnAppIconFetched(const SkBitmap& bitmap) {
209 if (bitmap.drawsNothing()) { 220 if (bitmap.drawsNothing()) {
210 ReportStatus(web_contents(), NO_ICON_AVAILABLE); 221 ReportStatus(web_contents(), NO_ICON_AVAILABLE);
211 Stop(); 222 Stop();
212 } 223 }
213 224
214 if (!is_active()) 225 if (!IsActive())
215 return; 226 return;
216 227
217 primary_icon_.reset(new SkBitmap(bitmap)); 228 primary_icon_.reset(new SkBitmap(bitmap));
218 SendBannerPromptRequest(); 229 SendBannerPromptRequest();
219 } 230 }
220 231
221 void AppBannerManagerAndroid::ResetCurrentPageData() { 232 void AppBannerManagerAndroid::ResetCurrentPageData() {
222 AppBannerManager::ResetCurrentPageData(); 233 AppBannerManager::ResetCurrentPageData();
223 native_app_data_.Reset(); 234 native_app_data_.Reset();
224 native_app_package_ = ""; 235 native_app_package_ = "";
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
356 } 367 }
357 368
358 // static 369 // static
359 void SetTotalEngagementToTrigger(JNIEnv* env, 370 void SetTotalEngagementToTrigger(JNIEnv* env,
360 const JavaParamRef<jclass>& clazz, 371 const JavaParamRef<jclass>& clazz,
361 jdouble engagement) { 372 jdouble engagement) {
362 AppBannerSettingsHelper::SetTotalEngagementToTrigger(engagement); 373 AppBannerSettingsHelper::SetTotalEngagementToTrigger(engagement);
363 } 374 }
364 375
365 } // namespace banners 376 } // namespace banners
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698