Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2778973003: Separate decoding module peak memory bytes for asm/wasm. (Closed)

Created:
3 years, 8 months ago by kschimpf
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com, wasm-v8_google.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Separate decoding module peak memory bytes for asm/wasm. Currently, V8 uses the same counter to measue module decoding peak memory bytes for both asm.js and WASM. This CL separates the counter into two separate counters, and then uses the appropriate counter when decoding a module. BUG=chromium:704922 R=bbudge@chromium.org,bradnelson@chromium.org,mtrofin@chromium.org Review-Url: https://codereview.chromium.org/2778973003 Cr-Commit-Position: refs/heads/master@{#44207} Committed: https://chromium.googlesource.com/v8/v8/+/759db9fcc88b3c99f4365f2db7d4441f284e76c1

Patch Set 1 #

Patch Set 2 : Fix merge with master conflicts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -53 lines) Patch
M src/counters.h View 1 2 chunks +55 lines, -51 lines 0 comments Download
M src/wasm/module-decoder.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
kschimpf
3 years, 8 months ago (2017-03-28 15:16:04 UTC) #5
bbudge
lgtm
3 years, 8 months ago (2017-03-28 17:14:31 UTC) #8
kschimpf
Need approval from either mtrofin or bradnelson to commit.
3 years, 8 months ago (2017-03-28 18:14:21 UTC) #11
bradnelson
lgtm
3 years, 8 months ago (2017-03-28 18:14:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778973003/1
3 years, 8 months ago (2017-03-28 18:14:34 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/37879)
3 years, 8 months ago (2017-03-28 18:21:00 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778973003/20001
3 years, 8 months ago (2017-03-28 19:24:51 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 20:00:18 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/759db9fcc88b3c99f4365f2db7d4441f284...

Powered by Google App Engine
This is Rietveld 408576698