Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 2778953004: [regexp] Properly handle failed RegExp compilations (Closed)

Created:
3 years, 8 months ago by jgruber
Modified:
3 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Properly handle failed RegExp compilations Compilation can fail e.g. on stack overflow. This ensures that we exit early from StringReplaceGlobalRegExpWithString in that case. BUG=v8:5437, chromium:705934 Review-Url: https://codereview.chromium.org/2778953004 Cr-Commit-Position: refs/heads/master@{#44215} Committed: https://chromium.googlesource.com/v8/v8/+/e2858f2adc4e8767576ab3adda61e37695bfd7be

Patch Set 1 #

Patch Set 2 : --stack-size #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M src/runtime/runtime-regexp.cc View 1 chunk +4 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-705934.js View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
jgruber
3 years, 8 months ago (2017-03-28 12:56:22 UTC) #4
Yang
On 2017/03/28 12:56:22, jgruber wrote: LGTM. Maybe you can add a --stack-size=100 flag to make ...
3 years, 8 months ago (2017-03-29 05:59:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778953004/20001
3 years, 8 months ago (2017-03-29 06:51:45 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 07:18:18 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/e2858f2adc4e8767576ab3adda61e37695b...

Powered by Google App Engine
This is Rietveld 408576698