Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2778933002: renderer-mus: Plumb LocalSurfaceId into RenderWidgetCompositor (Closed)

Created:
3 years, 9 months ago by Fady Samuel
Modified:
3 years, 8 months ago
Reviewers:
piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

renderer-mus: Plumb LocalSurfaceId into RenderWidgetCompositor If there is a RendererWindowTreeClient (Chrome is running in Mus-WS) then plumb the LocalSurfaceId out to RenderWidgetCompositor for surface synchronization. BUG=672962 Review-Url: https://codereview.chromium.org/2778933002 Cr-Commit-Position: refs/heads/master@{#460268} Committed: https://chromium.googlesource.com/chromium/src/+/3ab8e7fc26c16ec0c127b67d4f75a216eb85eb64

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/renderer/render_widget.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (16 generated)
Fady Samuel
3 years, 9 months ago (2017-03-28 01:23:21 UTC) #6
Fady Samuel
Gentle ping piman@
3 years, 8 months ago (2017-03-28 18:46:08 UTC) #7
piman
lgtm
3 years, 8 months ago (2017-03-28 21:57:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778933002/1
3 years, 8 months ago (2017-03-28 21:59:23 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/376971)
3 years, 8 months ago (2017-03-28 22:53:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778933002/1
3 years, 8 months ago (2017-03-28 22:59:35 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/377013)
3 years, 8 months ago (2017-03-28 23:08:56 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778933002/1
3 years, 8 months ago (2017-03-28 23:14:41 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder ...
3 years, 8 months ago (2017-03-29 00:45:26 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778933002/1
3 years, 8 months ago (2017-03-29 00:56:10 UTC) #22
commit-bot: I haz the power
Exceeded global retry quota
3 years, 8 months ago (2017-03-29 02:57:54 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778933002/1
3 years, 8 months ago (2017-03-29 02:59:29 UTC) #26
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 03:43:41 UTC) #29
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3ab8e7fc26c16ec0c127b67d4f75...

Powered by Google App Engine
This is Rietveld 408576698