Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 277893002: Cleaned up includes and unused declarations in the bookmarks component. (Closed)

Created:
6 years, 7 months ago by Joao da Silva
Modified:
6 years, 7 months ago
Reviewers:
blundell
CC:
chromium-reviews
Visibility:
Public.

Description

Cleaned up includes and unused declarations in the bookmarks component. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269562

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -17 lines) Patch
M components/bookmarks/core/browser/bookmark_client.h View 1 chunk +3 lines, -2 lines 0 comments Download
M components/bookmarks/core/browser/bookmark_codec.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/core/browser/bookmark_index.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/bookmarks/core/browser/bookmark_index.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/bookmarks/core/browser/bookmark_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/core/browser/bookmark_node.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M components/bookmarks/core/browser/bookmark_storage.h View 1 chunk +0 lines, -4 lines 1 comment Download
M components/bookmarks/core/browser/bookmark_storage.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/bookmarks/core/browser/bookmark_utils.h View 1 chunk +0 lines, -1 line 1 comment Download
M components/bookmarks/core/browser/bookmark_utils.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M components/bookmarks/core/common/bookmark_pref_names.h View 1 chunk +0 lines, -2 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
Joao da Silva
Hey Colin, did a little cleanup while looking into the bookmarks code. Can you have ...
6 years, 7 months ago (2014-05-09 09:59:34 UTC) #1
blundell
LGTM, thanks! https://codereview.chromium.org/277893002/diff/1/components/bookmarks/core/browser/bookmark_storage.h File components/bookmarks/core/browser/bookmark_storage.h (left): https://codereview.chromium.org/277893002/diff/1/components/bookmarks/core/browser/bookmark_storage.h#oldcode22 components/bookmarks/core/browser/bookmark_storage.h:22: class BrowserContext; :) https://codereview.chromium.org/277893002/diff/1/components/bookmarks/core/browser/bookmark_utils.h File components/bookmarks/core/browser/bookmark_utils.h (left): ...
6 years, 7 months ago (2014-05-09 10:02:11 UTC) #2
Joao da Silva
https://codereview.chromium.org/277893002/diff/1/components/bookmarks/core/common/bookmark_pref_names.h File components/bookmarks/core/common/bookmark_pref_names.h (left): https://codereview.chromium.org/277893002/diff/1/components/bookmarks/core/common/bookmark_pref_names.h#oldcode13 components/bookmarks/core/common/bookmark_pref_names.h:13: extern const char kBookmarkPromptEnabled[]; On 2014/05/09 10:02:11, blundell wrote: ...
6 years, 7 months ago (2014-05-09 10:06:08 UTC) #3
Joao da Silva
The CQ bit was checked by joaodasilva@chromium.org
6 years, 7 months ago (2014-05-09 10:06:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/277893002/1
6 years, 7 months ago (2014-05-09 10:10:43 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 11:48:18 UTC) #6
Message was sent while issue was closed.
Change committed as 269562

Powered by Google App Engine
This is Rietveld 408576698