components/bookmarks/core/common/bookmark_pref_names.h - Issue 277893002: Cleaned up includes and unused declarations in the bookmarks component.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/bookmarks/core/common/bookmark_pref_names.h

Issue 277893002: Cleaned up includes and unused declarations in the bookmarks component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« components/bookmarks/core/browser/bookmark_utils.h ('K') | « components/bookmarks/core/browser/bookmark_utils.cc ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Constants for the names of various bookmarks preferences.	5 // Constants for the names of various bookmarks preferences.

6	6

7 #ifndef COMPONENTS_BOOKMARKS_CORE_COMMON_BOOKMARK_PREF_NAMES_H_	7 #ifndef COMPONENTS_BOOKMARKS_CORE_COMMON_BOOKMARK_PREF_NAMES_H_

8 #define COMPONENTS_BOOKMARKS_CORE_COMMON_BOOKMARK_PREF_NAMES_H_	8 #define COMPONENTS_BOOKMARKS_CORE_COMMON_BOOKMARK_PREF_NAMES_H_

9	9

10 namespace prefs {	10 namespace prefs {

11	11

12 extern const char kBookmarkEditorExpandedNodes[];	12 extern const char kBookmarkEditorExpandedNodes[];

13 extern const char kBookmarkPromptEnabled[];
blundell 2014/05/09 10:02:11 these two don't exist anymore? these two don't exist anymore? Joao da Silva 2014/05/09 10:06:09 AFAICT this is dead code, I couldn't locate any re Show quoted text On 2014/05/09 10:02:11, blundell wrote: > these two don't exist anymore? AFAICT this is dead code, I couldn't locate any references to this. The try bots should find any potential sneaky users :-)
14 extern const char kBookmarkPromptImpressionCount[];

15 extern const char kShowBookmarkBar[];	13 extern const char kShowBookmarkBar[];

16 extern const char kEditBookmarksEnabled[];	14 extern const char kEditBookmarksEnabled[];

17 extern const char kShowAppsShortcutInBookmarkBar[];	15 extern const char kShowAppsShortcutInBookmarkBar[];

18	16

19 } // namespace prefs	17 } // namespace prefs

20	18

21 #endif // COMPONENTS_BOOKMARKS_CORE_COMMON_BOOKMARK_PREF_NAMES_H_	19 #endif // COMPONENTS_BOOKMARKS_CORE_COMMON_BOOKMARK_PREF_NAMES_H_

OLD	NEW