Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 2778833002: Revert changes to GPU test MessageLoop type. (Closed)

Created:
3 years, 9 months ago by kylechar
Modified:
3 years, 8 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert changes to GPU test MessageLoop type. Some GPU tests were changed to initialize a specific message loop type with Ozone in http://crrev.com/2682393003. This is no longer necessary after changing how Ozone GPU is initialized for tests in http://crrev.com/2773503003. BUG=686092 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2778833002 Cr-Commit-Position: refs/heads/master@{#460089} Committed: https://chromium.googlesource.com/chromium/src/+/1580a1f7b520c8ab7e6ff12c08c227ecc19df7cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -47 lines) Patch
M gpu/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 2 chunks +1 line, -3 lines 0 comments Download
M gpu/command_buffer/service/gpu_service_test.cc View 2 chunks +1 line, -5 lines 0 comments Download
M gpu/ipc/service/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/ipc/service/gpu_channel_unittest.cc View 2 chunks +1 line, -4 lines 0 comments Download
D gpu/test_message_loop_type.h View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
kylechar
3 years, 9 months ago (2017-03-27 19:56:42 UTC) #5
Ken Russell (switch to Gerrit)
lgtm
3 years, 9 months ago (2017-03-27 23:13:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778833002/1
3 years, 8 months ago (2017-03-28 14:06:27 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 14:11:35 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1580a1f7b520c8ab7e6ff12c08c2...

Powered by Google App Engine
This is Rietveld 408576698