Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2778813002: [ios] Add framework_dir flag to all_dependent_configs (-F). (Closed)

Created:
3 years, 9 months ago by sdefresne
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Add framework_dir flag to all_dependent_configs (-F). When building a custom framework, the framework and the framework_dir flags need to be added to the command-line of every linkable target the depends directly or indirectly on it. GN propagates properly the framework as it knows about "libs", but the -F flag added to ldflags need to be propagated using all_dependent_configs. BUG=704946 Review-Url: https://codereview.chromium.org/2778813002 Cr-Commit-Position: refs/heads/master@{#460071} Committed: https://chromium.googlesource.com/chromium/src/+/5376139411f2b362d24abc27425f3827697a46d4

Patch Set 1 #

Patch Set 2 : Rebase on origin/master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M build/config/ios/rules.gni View 2 chunks +14 lines, -8 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
sdefresne
Please take a look and send to CQ if LGTY :-)
3 years, 9 months ago (2017-03-27 14:15:35 UTC) #4
justincohen
lgtm
3 years, 9 months ago (2017-03-27 14:57:09 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 2772503006 Patch 20001). Please resolve the dependency and ...
3 years, 9 months ago (2017-03-27 16:01:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778813002/20001
3 years, 8 months ago (2017-03-28 11:40:21 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/5376139411f2b362d24abc27425f3827697a46d4
3 years, 8 months ago (2017-03-28 12:45:42 UTC) #15
malcombstewart58
lgtm
3 years, 8 months ago (2017-03-28 14:33:07 UTC) #17
malcombstewart58
3 years, 8 months ago (2017-03-28 14:33:12 UTC) #18
Message was sent while issue was closed.
lgtm

lgtm

lgtm

Powered by Google App Engine
This is Rietveld 408576698