content/browser/background_fetch/background_fetch_job_response_data.cc - Issue 2778793002: Start aligning BackgroundFetchRequestInfo with the passed in request object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/background_fetch/background_fetch_job_response_data.cc

Issue 2778793002: Start aligning BackgroundFetchRequestInfo with the passed in request object. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/background_fetch/background_fetch_job_controller_unittest.cc ('k') | content/browser/background_fetch/background_fetch_request_info.h » ('j') | content/browser/background_fetch/background_fetch_request_info.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/background_fetch/background_fetch_job_response_data.cc

diff --git a/content/browser/background_fetch/background_fetch_job_response_data.cc b/content/browser/background_fetch/background_fetch_job_response_data.cc

index d081de171eecf8ed1a9ebbe386b616c8bffa82b4..046ec8050d70fe534e9811cad4ffcd17c7d3fbf0 100644

--- a/content/browser/background_fetch/background_fetch_job_response_data.cc

+++ b/content/browser/background_fetch/background_fetch_job_response_data.cc

@@ -22,7 +22,7 @@ void BackgroundFetchJobResponseData::AddResponse(

const BackgroundFetchRequestInfo& request_info,

std::unique_ptr<BlobHandle> response) {

auto urls = base::MakeUnique<std::vector<GURL>>(std::vector<GURL>());

- urls->push_back(request_info.url());

+ urls->push_back(request_info.GetUrl());

// TODO(harkness): Fill in headers and status code/text.

auto headers = base::MakeUnique<ServiceWorkerHeaderMap>();