Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: content/browser/background_fetch/background_fetch_job_controller_unittest.cc

Issue 2778793002: Start aligning BackgroundFetchRequestInfo with the passed in request object. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/background_fetch/background_fetch_job_controller_unittest.cc
diff --git a/content/browser/background_fetch/background_fetch_job_controller_unittest.cc b/content/browser/background_fetch/background_fetch_job_controller_unittest.cc
index 22959816189334849c265623cc715a0492d0bbf5..160b0352606214b18efd68072ee07dc88a708792 100644
--- a/content/browser/background_fetch/background_fetch_job_controller_unittest.cc
+++ b/content/browser/background_fetch/background_fetch_job_controller_unittest.cc
@@ -17,6 +17,7 @@
#include "content/browser/background_fetch/background_fetch_data_manager.h"
#include "content/browser/background_fetch/background_fetch_job_info.h"
#include "content/browser/background_fetch/background_fetch_request_info.h"
+#include "content/common/service_worker/service_worker_types.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/test/fake_download_item.h"
#include "content/public/test/mock_download_manager.h"
@@ -204,7 +205,10 @@ class BackgroundFetchJobControllerTest : public ::testing::Test {
TEST_F(BackgroundFetchJobControllerTest, SingleRequestJob) {
BackgroundFetchJobInfo job_info(kTag, url::Origin(GURL(kOrigin)),
kServiceWorkerRegistrationId);
- BackgroundFetchRequestInfo request_info(GURL(kTestUrl), kJobGuid);
+ ServiceWorkerHeaderMap headers;
+ ServiceWorkerFetchRequest request(GURL(kTestUrl), "GET", headers, Referrer(),
+ false /* is_reload */);
+ BackgroundFetchRequestInfo request_info(request);
request_info.set_state(DownloadItem::DownloadState::IN_PROGRESS);
data_manager()->set_next_request(&request_info);
InitializeJobController();
@@ -240,7 +244,10 @@ TEST_F(BackgroundFetchJobControllerTest, MultipleRequestJob) {
kServiceWorkerRegistrationId);
std::vector<BackgroundFetchRequestInfo> request_infos;
for (int i = 0; i < 10; i++) {
- request_infos.emplace_back(GURL(kTestUrl), base::IntToString(i));
+ ServiceWorkerHeaderMap headers;
+ ServiceWorkerFetchRequest request(GURL(kTestUrl), "GET", headers,
+ Referrer(), false /* is_reload */);
+ request_infos.emplace_back(request);
}
data_manager()->set_next_request(&request_infos[0]);
InitializeJobController();
@@ -289,7 +296,10 @@ TEST_F(BackgroundFetchJobControllerTest, MultipleRequestJob) {
TEST_F(BackgroundFetchJobControllerTest, UpdateStorageState) {
BackgroundFetchJobInfo job_info(kTag, url::Origin(GURL(kOrigin)),
kServiceWorkerRegistrationId);
- BackgroundFetchRequestInfo request_info(GURL(kTestUrl), kJobGuid);
+ ServiceWorkerHeaderMap headers;
+ ServiceWorkerFetchRequest request(GURL(kTestUrl), "GET", headers, Referrer(),
+ false /* is_reload */);
+ BackgroundFetchRequestInfo request_info(request);
request_info.set_state(DownloadItem::DownloadState::IN_PROGRESS);
data_manager()->set_next_request(&request_info);
InitializeJobController();

Powered by Google App Engine
This is Rietveld 408576698