Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2778693005: Milo: Use LogDog URLs in top-level "Logs" field. (Closed)

Created:
3 years, 9 months ago by dnj
Modified:
3 years, 9 months ago
Reviewers:
hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Milo: Use LogDog URLs in top-level "Logs" field. The previous CL successfully updated log URLs in "steps", but left the top-level "Logs" links in-tact. While the "Logs" field is debatably useful and can probably be deleted, it should be correct for as long as it's there. BUG=chromium:701201 TEST=local Review-Url: https://codereview.chromium.org/2778693005 Committed: https://github.com/luci/luci-go/commit/61c57a82c980656476d196b36263b145834d93b4

Patch Set 1 #

Total comments: 4

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
M milo/appengine/buildbot/build.go View 1 3 chunks +33 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dnj
Don't hate me. PTAL
3 years, 9 months ago (2017-03-27 23:32:47 UTC) #2
hinoka
lgtm but rly who needs logs https://codereview.chromium.org/2778693005/diff/1/milo/appengine/buildbot/build.go File milo/appengine/buildbot/build.go (right): https://codereview.chromium.org/2778693005/diff/1/milo/appengine/buildbot/build.go#newcode518 milo/appengine/buildbot/build.go:518: linkMap := make(map[string]string) ...
3 years, 9 months ago (2017-03-27 23:40:29 UTC) #3
dnj
https://codereview.chromium.org/2778693005/diff/1/milo/appengine/buildbot/build.go File milo/appengine/buildbot/build.go (right): https://codereview.chromium.org/2778693005/diff/1/milo/appengine/buildbot/build.go#newcode518 milo/appengine/buildbot/build.go:518: linkMap := make(map[string]string) On 2017/03/27 23:40:29, hinoka wrote: > ...
3 years, 9 months ago (2017-03-27 23:44:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778693005/20001
3 years, 9 months ago (2017-03-27 23:49:20 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 23:55:17 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/61c57a82c980656476d196b36263b145834d93b4

Powered by Google App Engine
This is Rietveld 408576698