Milo: Use LogDog URLs in top-level "Logs" field.

Milo: Use LogDog URLs in top-level "Logs" field.

The previous CL successfully updated log URLs in "steps", but left the
top-level "Logs" links in-tact. While the "Logs" field is debatably
useful and can probably be deleted, it should be correct for as long as
it's there.

BUG=chromium:701201
TEST=local

Review-Url: https://codereview.chromium.org/2778693005
Committed: https://github.com/luci/luci-go/commit/61c57a82c980656476d196b36263b145834d93b4

[dnj, 2017-03-27 23:32:47]

dnj@chromium.org changed reviewers:
+ hinoka@chromium.org

[dnj, 2017-03-27 23:32:47]

Don't hate me. PTAL

[hinoka, 2017-03-27 23:40:29]

lgtm but rly who needs logs

https://codereview.chromium.org/2778693005/diff/1/milo/appengine/buildbot/bui...
File milo/appengine/buildbot/build.go (right):

https://codereview.chromium.org/2778693005/diff/1/milo/appengine/buildbot/bui...
milo/appengine/buildbot/build.go:518: linkMap := make(map[string]string)
nit: map[string]string{} will do.

https://codereview.chromium.org/2778693005/diff/1/milo/appengine/buildbot/bui...
milo/appengine/buildbot/build.go:605: if len(result) > 0 {
Add comment about why this chooses the last result (eg. // Any result will do)

[dnj, 2017-03-27 23:44:51]

https://codereview.chromium.org/2778693005/diff/1/milo/appengine/buildbot/bui...
File milo/appengine/buildbot/build.go (right):

https://codereview.chromium.org/2778693005/diff/1/milo/appengine/buildbot/bui...
milo/appengine/buildbot/build.go:518: linkMap := make(map[string]string)
On 2017/03/27 23:40:29, hinoka wrote:
> nit: map[string]string{} will do.

Done.

https://codereview.chromium.org/2778693005/diff/1/milo/appengine/buildbot/bui...
milo/appengine/buildbot/build.go:605: if len(result) > 0 {
On 2017/03/27 23:40:29, hinoka wrote:
> Add comment about why this chooses the last result (eg. // Any result will do)

Done.

[dnj, 2017-03-27 23:49:11]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-03-27 23:49:12]

The patchset sent to the CQ was uploaded after l-g-t-m from hinoka@chromium.org
Link to the patchset: https://codereview.chromium.org/2778693005/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2017-03-27 23:49:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 23:55:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490658551687410,
"parent_rev": "bd7c09a3a39523473f59ceb432b4f1dbc283c5c7", "commit_rev":
"61c57a82c980656476d196b36263b145834d93b4"}

[commit-bot: I haz the power, 2017-03-27 23:55:16]

Description was changed from

==========
Milo: Use LogDog URLs in top-level "Logs" field.

The previous CL successfully updated log URLs in "steps", but left the
top-level "Logs" links in-tact. While the "Logs" field is debatably
useful and can probably be deleted, it should be correct for as long as
it's there.

BUG=chromium:701201
TEST=local
==========

to

==========
Milo: Use LogDog URLs in top-level "Logs" field.

The previous CL successfully updated log URLs in "steps", but left the
top-level "Logs" links in-tact. While the "Logs" field is debatably
useful and can probably be deleted, it should be correct for as long as
it's there.

BUG=chromium:701201
TEST=local

Review-Url: https://codereview.chromium.org/2778693005
Committed:
https://github.com/luci/luci-go/commit/61c57a82c980656476d196b36263b145834d93b4
==========

[commit-bot: I haz the power, 2017-03-27 23:55:17]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/61c57a82c980656476d196b36263b145834d93b4