[DevTools] Migrate SoftContextMenu to use GlassPane

[DevTools] Migrate SoftContextMenu to use GlassPane

Let the GlassPane handle all the tricky details about positioning.

BUG=none

[dgozman, 2017-03-25 18:47:26]

dgozman@chromium.org changed reviewers:
+ lushnikov@chromium.org

[dgozman, 2017-03-25 18:47:27]

Could you please take a look?

[dgozman, 2017-03-25 18:47:31]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-25 18:47:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-25 18:49:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-25 18:49:33]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[dgozman, 2017-03-25 23:48:54]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-25 23:48:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-26 00:54:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-26 00:54:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lushnikov, 2017-03-27 18:08:33]

lgtm

https://codereview.chromium.org/2778623002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js (right):

https://codereview.chromium.org/2778623002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js:126:
document.body.addEventListener('click', this._onMouseDownBound, true);
is this change to better replicate softcontextmenu behavior?

https://codereview.chromium.org/2778623002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js (right):

https://codereview.chromium.org/2778623002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js:53:
this._glassPane.setSetOutsideClickCallback(event => {
setSet..?

I failed to come up with a good joke about this

[dgozman, 2017-03-27 23:08:09]

Thanks for review!

https://codereview.chromium.org/2778623002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js (right):

https://codereview.chromium.org/2778623002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js:126:
document.body.addEventListener('click', this._onMouseDownBound, true);
On 2017/03/27 18:08:33, lushnikov wrote:
> is this change to better replicate softcontextmenu behavior?

Yep.

https://codereview.chromium.org/2778623002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js (right):

https://codereview.chromium.org/2778623002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js:53:
this._glassPane.setSetOutsideClickCallback(event => {
On 2017/03/27 18:08:33, lushnikov wrote:
> setSet..?
> 
> I failed to come up with a good joke about this

I'll fixFix it in a follow up :-)

[dgozman, 2017-03-27 23:08:16]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2017-03-27 23:09:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 00:31:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490656096237680,
"parent_rev": "dcd658078eb85cce9219179d89be4df627d9d3a3", "commit_rev":
"d5f25f6e1a4b59c43fb7a1fdfb68e2e49df8f62b"}

[commit-bot: I haz the power, 2017-03-28 00:38:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 00:38:33]

Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

[dgozman, 2017-03-28 01:11:36]

On 2017/03/28 00:38:33, commit-bot: I haz the power wrote:
> Prior attempt to commit was detected, but we were not able to check whether
the
> issue was successfully committed. Please check Git history manually and
re-check
> CQ or close this issue as needed.

Landed as crrev.com/d5f25f6e1a4b59c43fb7a1fdfb68e2e49df8f62b

[alph, 2017-03-28 21:27:04]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2771413006/ by alph@chromium.org.

The reason for reverting is: Broke DevTools settings.