Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1929)

Unified Diff: appengine/components/components/config/api_test.py

Issue 2778533002: config: store binary configs (Closed)
Patch Set: addressed comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/components/components/config/api.py ('k') | appengine/components/components/config/fs.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/components/components/config/api_test.py
diff --git a/appengine/components/components/config/api_test.py b/appengine/components/components/config/api_test.py
index df459fe7dc6144a26cd47047ed9edb6c741bd60f..bbb3afd628991a268fa8cea1daaa292527dd4f10 100755
--- a/appengine/components/components/config/api_test.py
+++ b/appengine/components/components/config/api_test.py
@@ -33,7 +33,7 @@ class ApiTestCase(test_case.TestCase):
self.mock(config.api, '_get_config_provider_async', lambda: provider_future)
self.provider.get_async.return_value = ndb.Future()
self.provider.get_async.return_value.set_result(
- ('deadbeef', 'param: "value"'))
+ ('deadbeef', test_config_pb2.Config(param='value')))
def test_get(self):
revision, cfg = config.get(
@@ -53,14 +53,10 @@ class ApiTestCase(test_case.TestCase):
self.assertEqual(cfg.param, 'value')
def test_get_ref_config(self):
- revision, cfg = config.get_ref_config('foo', 'refs/x', 'bar.cfg')
+ revision, cfg = config.get_ref_config(
+ 'foo', 'refs/x', 'bar.cfg', test_config_pb2.Config)
self.assertEqual(revision, 'deadbeef')
- self.assertEqual(cfg, 'param: "value"')
-
- def test_cannot_load_config(self):
- self.provider.get_async.side_effect = ValueError
- with self.assertRaises(config.CannotLoadConfigError):
- config.get('services/foo', 'bar.cfg')
+ self.assertEqual(cfg, test_config_pb2.Config(param='value'))
def test_get_projects(self):
self.provider.get_projects_async.return_value = ndb.Future()
« no previous file with comments | « appengine/components/components/config/api.py ('k') | appengine/components/components/config/fs.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698