Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1989)

Unified Diff: appengine/components/components/config/api.py

Issue 2778533002: config: store binary configs (Closed)
Patch Set: addressed comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/components/PRESUBMIT.py ('k') | appengine/components/components/config/api_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/components/components/config/api.py
diff --git a/appengine/components/components/config/api.py b/appengine/components/components/config/api.py
index 095afdc84206904dd54da8b2f50254935b729ef7..c3f3b875c371c087ec8c461c7d11b4006db4ef7e 100644
--- a/appengine/components/components/config/api.py
+++ b/appengine/components/components/config/api.py
@@ -79,7 +79,6 @@ def get_async(
NotImplementedError if |dest_type| is not supported.
ValueError on invalid parameter.
ConfigFormatError if config could not be converted to |dest_type|.
- CannotLoadConfigError if could not load a config.
"""
assert config_set
assert path
@@ -92,9 +91,10 @@ def get_async(
'specified')
provider = yield _get_config_provider_async()
- revision, config = yield provider.get_async(
- config_set, path, revision=revision, store_last_good=store_last_good)
- raise ndb.Return((revision, common._convert_config(config, dest_type)))
+ result = yield provider.get_async(
+ config_set, path, revision=revision, dest_type=dest_type,
+ store_last_good=store_last_good)
+ raise ndb.Return(result)
def get(*args, **kwargs):
« no previous file with comments | « appengine/components/PRESUBMIT.py ('k') | appengine/components/components/config/api_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698