Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4185)

Unified Diff: chrome/browser/ui/browser_command_controller.cc

Issue 2778523002: Revert change http://crrev.com/3c7af99a93f4b4837b2fbee5cb66697f66ccf241/ (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/browser_command_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_command_controller.cc
diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc
index 8d6f45fee3819cef94e5c58dd296ad63fd1acd23..ad174159d46d1b64968431abdb03a1f2a407d6f5 100644
--- a/chrome/browser/ui/browser_command_controller.cc
+++ b/chrome/browser/ui/browser_command_controller.cc
@@ -187,11 +187,8 @@ bool BrowserCommandController::IsReservedCommandOrKey(
}
#endif
- if (window()->IsFullscreen()) {
- // In fullscreen, all commands except for IDC_FULLSCREEN and IDC_EXIT should
- // be delivered to the web page. See, intent to implement,
- // https://goo.gl/4tJ32G.
- return command_id == IDC_EXIT || command_id == IDC_FULLSCREEN;
+ if (window()->IsFullscreen() && command_id == IDC_FULLSCREEN) {
msw 2017/03/25 01:07:26 optional nit: curlies not needed
Hzj_jie 2017/03/25 02:19:19 Different culture :)
+ return true;
}
#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
« no previous file with comments | « no previous file | chrome/browser/ui/browser_command_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698