Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2778463003:
[cr elements] icon buttons under toolbar have white focus circle (Closed)
|
Created:
3 years, 9 months ago by dschuyler Modified:
3 years, 8 months ago CC:
chromium-reviews, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-elements_chromium.org, oshima+watch_chromium.org, tsergeant Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[cr elements] icon buttons under toolbar have white focus circle
This CL makes the paper icon button focus ripples (disc) consistent.
Before this CL, the menu icon and clear search icon had a different
focus color than the search icon, for example. Alan wants them to all
have a white focus highlight.
This is a step toward fixing the bug (not a complete fix).
BUG=693383
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2778463003
Cr-Commit-Position: refs/heads/master@{#460493}
Committed: https://chromium.googlesource.com/chromium/src/+/f644b85dd6827427131f3b227d96e9c3b1ca9815
Patch Set 1 #
Total comments: 1
Messages
Total messages: 21 (13 generated)
Description was changed from ========== [cr elements] icon buttons under toolbar have white focus circle This CL makes the paper icon button focus ripples (disc) consistent. Before this CL, the menu icon and clear search icon had a different focus color than the search icon, for example. Alan wants them to all have a white focus highlight. This is a step toward fixing the bug (not a complete fix). BUG=693383 ========== to ========== [cr elements] icon buttons under toolbar have white focus circle This CL makes the paper icon button focus ripples (disc) consistent. Before this CL, the menu icon and clear search icon had a different focus color than the search icon, for example. Alan wants them to all have a white focus highlight. This is a step toward fixing the bug (not a complete fix). BUG=693383 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dschuyler@chromium.org changed reviewers: + tommycli@chromium.org
Note that this change also affects chrome://history (any page that uses cr-toolbar).
Description was changed from ========== [cr elements] icon buttons under toolbar have white focus circle This CL makes the paper icon button focus ripples (disc) consistent. Before this CL, the menu icon and clear search icon had a different focus color than the search icon, for example. Alan wants them to all have a white focus highlight. This is a step toward fixing the bug (not a complete fix). BUG=693383 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [cr elements] icon buttons under toolbar have white focus circle This CL makes the paper icon button focus ripples (disc) consistent. Before this CL, the menu icon and clear search icon had a different focus color than the search icon, for example. Alan wants them to all have a white focus highlight. This is a step toward fixing the bug (not a complete fix). BUG=693383 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
dbeam@chromium.org changed reviewers: + dbeam@chromium.org
lgtm but fwiw I think we might not have these issues with paper-icon-button-light https://codereview.chromium.org/2778463003/diff/1/ui/webui/resources/cr_eleme... File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html (right): https://codereview.chromium.org/2778463003/diff/1/ui/webui/resources/cr_eleme... ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html:12: --paper-icon-button-ink-color: white; note: it'd be nice if you somehow joined with the "color: #fff" below by making them a variable, maybe figuring out how to set --primary-text-color: white; or some other means. most ripples just set their background color from "currentcolor", but paper-icon-button seems to be a special flower in this regard. https://developer.mozilla.org/en-US/docs/Web/CSS/color_value#currentcolor_key...
rs lgtm
On 2017/03/27 12:13:05, Dan Beam (slow) wrote: > lgtm but fwiw I think we might not have these issues with > paper-icon-button-light I wondered about making these paper-icon-button-light. I'd like to look into that as a follow-up. > https://codereview.chromium.org/2778463003/diff/1/ui/webui/resources/cr_eleme... > File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html (right): > > https://codereview.chromium.org/2778463003/diff/1/ui/webui/resources/cr_eleme... > ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html:12: > --paper-icon-button-ink-color: white; > note: it'd be nice if you somehow joined with the "color: #fff" below by making > them a variable, maybe figuring out how to set --primary-text-color: white; or > some other means. Iff paper-icon-button-light works out, then this can be removed (which sounds even better to me). If that doesn't workout I'll look into the vars and colors as suggested. > most ripples just set their background color from "currentcolor", but > paper-icon-button seems to be a special flower in this regard. > > https://developer.mozilla.org/en-US/docs/Web/CSS/color_value#currentcolor_key...
The CQ bit was checked by dschuyler@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by dschuyler@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490812097212880, "parent_rev":
"9ac9895f221d2ca88e4537bd9304ad679c0e5771", "commit_rev":
"f644b85dd6827427131f3b227d96e9c3b1ca9815"}
Message was sent while issue was closed.
Description was changed from ========== [cr elements] icon buttons under toolbar have white focus circle This CL makes the paper icon button focus ripples (disc) consistent. Before this CL, the menu icon and clear search icon had a different focus color than the search icon, for example. Alan wants them to all have a white focus highlight. This is a step toward fixing the bug (not a complete fix). BUG=693383 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [cr elements] icon buttons under toolbar have white focus circle This CL makes the paper icon button focus ripples (disc) consistent. Before this CL, the menu icon and clear search icon had a different focus color than the search icon, for example. Alan wants them to all have a white focus highlight. This is a step toward fixing the bug (not a complete fix). BUG=693383 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2778463003 Cr-Commit-Position: refs/heads/master@{#460493} Committed: https://chromium.googlesource.com/chromium/src/+/f644b85dd6827427131f3b227d96... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f644b85dd6827427131f3b227d96... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
