Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 2778443003: [wasm] Use new override mechanism for wasm limits (Closed)

Created:
3 years, 9 months ago by Mircea Trofin
Modified:
3 years, 9 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use new override mechanism for wasm limits. This allows us to throw specific error messages (see CL) for the wasm size limits on the main thread. We'll furthermore use this mechanism to add the WebAssembly.compile and .instantiate overloads that take Response objects as parameters (separate CL). BUG=v8:6027 Review-Url: https://codereview.chromium.org/2778443003 Cr-Commit-Position: refs/heads/master@{#459844} Committed: https://chromium.googlesource.com/chromium/src/+/f6708b17d7e4bc590d9e6186a520f31082554603

Patch Set 1 : Use new override mechanism for wasm limits #

Patch Set 2 : regression tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -34 lines) Patch
M third_party/WebKit/LayoutTests/fast/wasm/wasm-limits-test.html View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/wasm/wasm-limits-tests.js View 1 1 chunk +28 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 1 4 chunks +53 lines, -34 lines 0 comments Download

Messages

Total messages: 23 (19 generated)
Mircea Trofin
3 years, 9 months ago (2017-03-25 16:36:09 UTC) #10
jochen (gone - plz use gerrit)
please reference a bug id from the cl description otherwise, lgtm
3 years, 9 months ago (2017-03-27 12:40:50 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778443003/40001
3 years, 9 months ago (2017-03-27 15:15:46 UTC) #20
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 19:08:14 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f6708b17d7e4bc590d9e6186a520...

Powered by Google App Engine
This is Rietveld 408576698