Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2778433002: Reland "Move geometry interface files to geometry directory." (Closed)

Created:
3 years, 9 months ago by Byoungkwon Ko
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews, sof, eae+blinkwatch, abarth-chromium, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, blink-reviews, rwlbuis, foolip, zino, dominicc (has gone to gerrit)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Move geometry interface files to geometry directory." Reason for revert: Had to change the location of generated cpp and header file for IDL dictionary in bindings/core/v8/BUILD.gn but it didn't. So, build was broken. Original issue number: https://codereview.chromium.org/2741723005/ Original issue's description: > The geometry interfaces such as DOMMatrix, DOMRect and so on can be shared > in a lot of modules such as dom, css and so on. Also, it is not very relevant > to the DOM, so it is proper to create a new geometry directory and then move > the related files to the directory. > > [1/2] This Patch (Move DOMMatrix related files to geometry folder) > [2/2] https://codereview.chromium.org/2709763004/ (Make WebKitCSSMatrix an > alias of DOMMatrix.) BUG=581955 Review-Url: https://codereview.chromium.org/2778433002 Cr-Commit-Position: refs/heads/master@{#459612} Committed: https://chromium.googlesource.com/chromium/src/+/ceec5078d982398f334025bb4c2bb5c01d39d42c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -1951 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/BUILD.gn View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 3 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/core_idl_files.gni View 2 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/dom/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/dom/CompositorProxy.h View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/core/dom/DOMMatrix.h View 1 chunk +0 lines, -121 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMMatrix.cpp View 1 chunk +0 lines, -267 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMMatrix.idl View 1 chunk +0 lines, -74 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMMatrixInit.idl View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h View 1 chunk +0 lines, -140 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp View 1 chunk +0 lines, -398 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.idl View 1 chunk +0 lines, -82 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMMatrixTest.cpp View 1 chunk +0 lines, -151 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMPoint.h View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMPoint.cpp View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMPoint.idl View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMPointInit.idl View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMPointReadOnly.h View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMPointReadOnly.cpp View 1 chunk +0 lines, -66 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMPointReadOnly.idl View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMQuad.h View 1 chunk +0 lines, -70 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMQuad.cpp View 1 chunk +0 lines, -80 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMQuad.idl View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMQuadInit.idl View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMRect.h View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMRect.cpp View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMRect.idl View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMRectInit.idl View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMRectReadOnly.h View 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMRectReadOnly.cpp View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/Source/core/dom/DOMRectReadOnly.idl View 1 chunk +0 lines, -25 lines 0 comments Download
A third_party/WebKit/Source/core/geometry/BUILD.gn View 1 chunk +31 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/geometry/DOMMatrix.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/core/geometry/DOMMatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/geometry/DOMMatrix.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/geometry/DOMMatrixInit.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/geometry/DOMMatrixTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/geometry/DOMPoint.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/geometry/DOMPoint.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/core/geometry/DOMPoint.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/geometry/DOMPointInit.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/geometry/DOMPointReadOnly.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/geometry/DOMPointReadOnly.cpp View 2 chunks +6 lines, -7 lines 0 comments Download
A + third_party/WebKit/Source/core/geometry/DOMPointReadOnly.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/geometry/DOMQuad.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/geometry/DOMQuad.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/core/geometry/DOMQuad.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/geometry/DOMQuadInit.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/geometry/DOMRect.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/geometry/DOMRect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/core/geometry/DOMRect.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/geometry/DOMRectInit.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/geometry/DOMRectReadOnly.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/geometry/DOMRectReadOnly.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/core/geometry/DOMRectReadOnly.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/Source/core/geometry/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/DetectedBarcode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/DetectedFace.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/DetectedText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Byoungkwon Ko
haraken@ Could you review this as owner of both of bindings and core? This patch ...
3 years, 9 months ago (2017-03-24 15:31:01 UTC) #4
haraken
On 2017/03/24 15:31:01, Byoungkwon Ko wrote: > haraken@ > > Could you review this as ...
3 years, 9 months ago (2017-03-24 16:02:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778433002/1
3 years, 9 months ago (2017-03-25 00:57:48 UTC) #9
esprehn
How did it make it through the CQ with broken build files?
3 years, 9 months ago (2017-03-25 00:58:57 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ceec5078d982398f334025bb4c2bb5c01d39d42c
3 years, 9 months ago (2017-03-25 01:05:31 UTC) #13
Byoungkwon Ko
3 years, 9 months ago (2017-03-25 01:10:13 UTC) #14
Message was sent while issue was closed.
On 2017/03/25 00:58:57, esprehn wrote:
> How did it make it through the CQ with broken build files?

I don't know how it was success on CQ.
But all of result was passed  then I pushed them.

Powered by Google App Engine
This is Rietveld 408576698