Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 2778373003: Reporting: Add Observer interface to observe cache updates. (Closed)

Created:
3 years, 8 months ago by Julia Tuttle
Modified:
3 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reporting: Add Observer interface to observe cache updates. Reporting is a spec for delivering out-of-band reports from various other parts of the browser. See http://wicg.github.io/reporting/ for the spec, or https://goo.gl/pygX5I for details of the planned implementation in Chromium. This adds an Observer interface by which parts of Reporting can observe cache updates. Expected users are the DeliveryAgent and Serializer. BUG=704259 Review-Url: https://codereview.chromium.org/2778373003 Cr-Commit-Position: refs/heads/master@{#462980} Committed: https://chromium.googlesource.com/chromium/src/+/48f489e9d57806e4e78039e4712721ba141229d7

Patch Set 1 #

Patch Set 2 : switch to ObserverList, rebase, etc. #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -0 lines) Patch
M net/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M net/reporting/reporting_cache.cc View 8 chunks +19 lines, -0 lines 0 comments Download
M net/reporting/reporting_cache_unittest.cc View 17 chunks +42 lines, -0 lines 0 comments Download
M net/reporting/reporting_context.h View 1 2 3 4 chunks +9 lines, -0 lines 0 comments Download
M net/reporting/reporting_context.cc View 1 2 3 3 chunks +17 lines, -0 lines 0 comments Download
A net/reporting/reporting_observer.h View 1 chunk +27 lines, -0 lines 0 comments Download
A net/reporting/reporting_observer.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 20 (14 generated)
Julia Tuttle
PTAL, shivanisha.
3 years, 8 months ago (2017-03-28 23:36:06 UTC) #2
shivanisha
On 2017/03/28 at 23:36:06, juliatuttle wrote: > PTAL, shivanisha. Lgtm
3 years, 8 months ago (2017-04-07 15:01:36 UTC) #11
Julia Tuttle
PTAL csharrison for committer signoff.
3 years, 8 months ago (2017-04-07 15:54:35 UTC) #13
Charlie Harrison
RS LGTM
3 years, 8 months ago (2017-04-07 16:31:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778373003/60001
3 years, 8 months ago (2017-04-07 18:56:57 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 20:15:58 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/48f489e9d57806e4e78039e47127...

Powered by Google App Engine
This is Rietveld 408576698