Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 2778323002: New VS 2017 toolchain with dbghelp.dll fixes (Closed)

Created:
3 years, 8 months ago by brucedawson
Modified:
3 years, 8 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

New VS 2017 toolchain with dbghelp.dll fixes This updates the package used when building Chrome with VS 2017 based on the changes in https://chromium-review.googlesource.com/461385. This packages versions of dbghelp.dll that can handle VS 2017's /debug:fastlink binaries without hanging. This avoids hangs in windbg and in base_unittests, and elsewhere. See this bug for details: https://developercommunity.visualstudio.com/content/problem/36255/chromes-base-unittests-fails-with-vs-2017-due-to-s.html R=scottmg@chromium.org BUG=683729 Review-Url: https://codereview.chromium.org/2778323002 Cr-Commit-Position: refs/heads/master@{#460236} Committed: https://chromium.googlesource.com/chromium/src/+/6a01e98bf1f7cd1b9418698808ae83fca54fb626

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/vs_toolchain.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
brucedawson
This is a follow-on to the packaging changes.
3 years, 8 months ago (2017-03-28 20:05:52 UTC) #1
scottmg
lgtm
3 years, 8 months ago (2017-03-28 20:08:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778323002/1
3 years, 8 months ago (2017-03-28 20:34:09 UTC) #4
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
3 years, 8 months ago (2017-03-28 21:04:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778323002/1
3 years, 8 months ago (2017-03-28 21:24:28 UTC) #8
commit-bot: I haz the power
CQ has no permission to schedule in bucket master.tryserver.chromium.win
3 years, 8 months ago (2017-03-28 21:24:43 UTC) #10
scottmg
this cq seems about as good as copying dbghelp.dll all over the place.
3 years, 8 months ago (2017-03-28 21:32:49 UTC) #11
brucedawson
On 2017/03/28 21:32:49, scottmg wrote: > this cq seems about as good as copying dbghelp.dll ...
3 years, 8 months ago (2017-03-28 21:33:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778323002/1
3 years, 8 months ago (2017-03-28 23:05:53 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 23:30:15 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6a01e98bf1f7cd1b9418698808ae...

Powered by Google App Engine
This is Rietveld 408576698