Check apk and dex files on Chrome OS.

Change Chrome behavior on handling Android executables on CrOS.

ARC++ allows Android app to run on Chrome OS. It is necessary to change
the behavior of Chrome on CrOS on handling apk and dex files. This CL
prevents auto download apk and dex file on CrOS and also disallow auto
open such files.

BUG=694872
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2778283003
Cr-Commit-Position: refs/heads/master@{#460583}
Committed: https://chromium.googlesource.com/chromium/src/+/7b657dbed2d31e0497261633902d2c8e0a5cdf4b

[xzhou, 2017-03-28 22:48:26]

Description was changed from

==========
Check apk and dex files on Chrome OS.

ARC++ allows Android app to run on Chrome OS. It is necessary to check
Android executables on Chrome OS.

BUG=b:694872
==========

to

==========
Check apk and dex files on Chrome OS.

ARC++ allows Android app to run on Chrome OS. It is necessary to check
Android executables on Chrome OS.

BUG=b:694872
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[xzhou, 2017-03-28 22:51:16]

The CQ bit was checked by xzhou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 22:51:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xzhou, 2017-03-28 22:53:24]

xzhou@chromium.org changed reviewers:
+ jialiul@chromium.org

[xzhou, 2017-03-28 23:00:58]

The CQ bit was checked by xzhou@chromium.org to run a CQ dry run

[xzhou, 2017-03-28 23:01:19]

Description was changed from

==========
Check apk and dex files on Chrome OS.

ARC++ allows Android app to run on Chrome OS. It is necessary to check
Android executables on Chrome OS.

BUG=b:694872
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Check apk and dex files on Chrome OS.

ARC++ allows Android app to run on Chrome OS. It is necessary to check
Android executables on Chrome OS.

BUG=694872
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2017-03-28 23:01:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jialiu Lin, 2017-03-28 23:07:33]

Description was changed from

==========
Check apk and dex files on Chrome OS.

ARC++ allows Android app to run on Chrome OS. It is necessary to check
Android executables on Chrome OS.

BUG=694872
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Check apk and dex files on Chrome OS.

ARC++ allows Android app to run on Chrome OS. It is necessary to check
Android executables on Chrome OS.

BUG=b:694872
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Jialiu Lin, 2017-03-28 23:07:34]

jialiul@chromium.org changed reviewers:
+ nparker@chromium.org

[Jialiu Lin, 2017-03-28 23:09:30]

lgtm

We probably should not expose buganizer bug number in this Chromium cl. Could
you use a chromium bug ID instead?

[xzhou, 2017-03-28 23:12:17]

Description was changed from

==========
Check apk and dex files on Chrome OS.

ARC++ allows Android app to run on Chrome OS. It is necessary to check
Android executables on Chrome OS.

BUG=b:694872
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Check apk and dex files on Chrome OS.

ARC++ allows Android app to run on Chrome OS. It is necessary to check
Android executables on Chrome OS.

BUG=694872
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[xzhou, 2017-03-28 23:14:01]

On 2017/03/28 23:09:30, Jialiu Lin wrote:
> lgtm
> 
> We probably should not expose buganizer bug number in this Chromium cl. Could
> you use a chromium bug ID instead?

Done. I already updated the BUG= in git commit log and also edited the
Description here.

[commit-bot: I haz the power, 2017-03-29 01:04:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 01:04:59]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)

[xzhou, 2017-03-29 01:19:14]

Description was changed from

==========
Check apk and dex files on Chrome OS.

ARC++ allows Android app to run on Chrome OS. It is necessary to check
Android executables on Chrome OS.

BUG=694872
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Change Chrome behavior on handling Android executables on CrOS.
    
    ARC++ allows Android app to run on Chrome OS. It is necessary to change
    the behavior of Chrome on CrOS on handling apk and dex files. This CL
    prevents auto download apk and dex file on CrOS and also disallow auto
    open such files.
    
    BUG=694872
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[xzhou, 2017-03-29 01:19:58]

Description was changed from

==========
Change Chrome behavior on handling Android executables on CrOS.
    
    ARC++ allows Android app to run on Chrome OS. It is necessary to change
    the behavior of Chrome on CrOS on handling apk and dex files. This CL
    prevents auto download apk and dex file on CrOS and also disallow auto
    open such files.
    
    BUG=694872
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Change Chrome behavior on handling Android executables on CrOS.

ARC++ allows Android app to run on Chrome OS. It is necessary to change
the behavior of Chrome on CrOS on handling apk and dex files. This CL
prevents auto download apk and dex file on CrOS and also disallow auto
open such files.

BUG=694872

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[xzhou, 2017-03-29 01:23:21]

The CQ bit was checked by xzhou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 01:23:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 03:01:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 03:01:06]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xzhou, 2017-03-29 17:33:08]

The CQ bit was checked by xzhou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 17:33:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xzhou, 2017-03-29 17:34:11]

The CQ bit was unchecked by xzhou@chromium.org

[Jialiu Lin, 2017-03-29 20:19:33]

Hi xzhou,
Could you fix the broken unittest for "dex"? 
https://cs.chromium.org/chromium/src/chrome/common/safe_browsing/file_type_po...

You just need to change 
"#if defined(OS_ANDROID)"
into
"#if defined(OS_ANDROID) && defined(OS_CHROMEOS)

Sorry for not catching this earlier.

[Nathan Parker, 2017-03-29 20:28:37]

lgtm

https://codereview.chromium.org/2778283003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/safe_browsing/download_file_types.asciipb (right):

https://codereview.chromium.org/2778283003/diff/40001/chrome/browser/resource...
chrome/browser/resources/safe_browsing/download_file_types.asciipb:2642: #
warning to provide a speed bump for dangerous file types.
Add a comment that some Chrome OS installations can now execute android APKs, to
explain the chromeos settings.

[xzhou, 2017-03-29 21:04:28]

The CQ bit was checked by xzhou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 21:05:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xzhou, 2017-03-29 21:05:44]

The CQ bit was unchecked by xzhou@chromium.org

[xzhou, 2017-03-29 21:06:14]

The CQ bit was checked by xzhou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 21:07:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 22:37:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 22:37:11]

Dry run: This issue passed the CQ dry run.

[xzhou, 2017-03-29 22:52:03]

On 2017/03/29 20:19:33, Jialiu Lin wrote:
> Hi xzhou,
> Could you fix the broken unittest for "dex"? 
>
https://cs.chromium.org/chromium/src/chrome/common/safe_browsing/file_type_po...
> 
> You just need to change 
> "#if defined(OS_ANDROID)"
> into
> "#if defined(OS_ANDROID) && defined(OS_CHROMEOS)
> 
> Sorry for not catching this earlier.

Done.

[xzhou, 2017-03-29 22:53:22]

On 2017/03/29 20:19:33, Jialiu Lin wrote:
> Hi xzhou,
> Could you fix the broken unittest for "dex"? 
>
https://cs.chromium.org/chromium/src/chrome/common/safe_browsing/file_type_po...
> 
> You just need to change 
> "#if defined(OS_ANDROID)"
> into
> "#if defined(OS_ANDROID) && defined(OS_CHROMEOS)
> 
> Sorry for not catching this earlier.

I changed the it to so the unit test treat OS_ANDROID and OS_CHROMEOS the same
like this.

#if defined(OS_ANDROID) || defined(OS_CHROMEOS)

[xzhou, 2017-03-29 23:45:36]

The CQ bit was checked by xzhou@chromium.org

[xzhou, 2017-03-29 23:45:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
jialiul@chromium.org, nparker@chromium.org
Link to the patchset: https://codereview.chromium.org/2778283003/#ps60001
(title: "Fix file_type_policies_unittest.")

[commit-bot: I haz the power, 2017-03-29 23:46:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 23:55:25]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490831136650590,
"parent_rev": "6b61964c84f3d3bdcb1f8bc0e136e992f9ae7758", "commit_rev":
"7b657dbed2d31e0497261633902d2c8e0a5cdf4b"}

[commit-bot: I haz the power, 2017-03-29 23:56:09]

Description was changed from

==========
Change Chrome behavior on handling Android executables on CrOS.

ARC++ allows Android app to run on Chrome OS. It is necessary to change
the behavior of Chrome on CrOS on handling apk and dex files. This CL
prevents auto download apk and dex file on CrOS and also disallow auto
open such files.

BUG=694872

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Change Chrome behavior on handling Android executables on CrOS.

ARC++ allows Android app to run on Chrome OS. It is necessary to change
the behavior of Chrome on CrOS on handling apk and dex files. This CL
prevents auto download apk and dex file on CrOS and also disallow auto
open such files.

BUG=694872

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2778283003
Cr-Commit-Position: refs/heads/master@{#460583}
Committed:
https://chromium.googlesource.com/chromium/src/+/7b657dbed2d31e0497261633902d...
==========

[commit-bot: I haz the power, 2017-03-29 23:56:10]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/7b657dbed2d31e0497261633902d...