Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Issue 2778223003: Upstream service worker `controller` tests to WPT (Closed)

Created:
3 years, 8 months ago by mike3
Modified:
3 years, 8 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, blink-reviews-w3ctests_chromium.org, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream service worker `controller` tests to WPT The Web Platform Tests project includes equivalent versions of these tests. Those copies have since been extended with additional assertions, rendering the Chromium versions obsolve. Remove the Chromium tests in favor of the more rigorous WPT versions. Correct a small formatting error introduced by the extension to the WPT tests. BUG=688116 R=falken@chromium.org Review-Url: https://codereview.chromium.org/2778223003 Cr-Commit-Position: refs/heads/master@{#460405} Committed: https://chromium.googlesource.com/chromium/src/+/68b9ec68fc7709b47a66fe10320b64c5b008e79d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -74 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/controller-on-load.https.html View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/controller-on-load.html View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/controller-on-reload.html View 1 chunk +0 lines, -43 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mike3
Hi @falken! Hopefully this one will be a little less annoying for you :P Here's ...
3 years, 8 months ago (2017-03-28 22:52:05 UTC) #1
falken
lgtm, great. typo in CL description: "client" -> "controller"
3 years, 8 months ago (2017-03-29 03:57:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778223003/1
3 years, 8 months ago (2017-03-29 14:46:27 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 16:07:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/68b9ec68fc7709b47a66fe10320b...

Powered by Google App Engine
This is Rietveld 408576698