Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Issue 2778193003: Don't access destroyed web contents. (Closed)

Created:
3 years, 8 months ago by please use gerrit instead
Modified:
3 years, 8 months ago
Reviewers:
nyquist
CC:
chromium-reviews, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't access destroyed web contents. Before this change, selecting "Close all incognito windows" while Chrome was showing "You're leaving incognito mode" warning dialog will cause a crash. After this change, the crash is avoided. BUG=705844 Review-Url: https://codereview.chromium.org/2778193003 Cr-Commit-Position: refs/heads/master@{#460574} Committed: https://chromium.googlesource.com/chromium/src/+/6f0e189728f2cceb9534536cd175787da5f3c0e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
please use gerrit instead
nyquist, ptal. The change to AndroidPaymentApp.java fixes the bug in question. The change to ChromeActivity.java ...
3 years, 8 months ago (2017-03-28 15:04:09 UTC) #5
nyquist
The code looks OK, but could you please expand the CL description? Maybe you could ...
3 years, 8 months ago (2017-03-29 20:43:15 UTC) #8
nyquist
lgtm
3 years, 8 months ago (2017-03-29 21:16:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778193003/20001
3 years, 8 months ago (2017-03-29 21:18:19 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 23:26:38 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6f0e189728f2cceb9534536cd175...

Powered by Google App Engine
This is Rietveld 408576698