Don't access destroyed web contents.

Don't access destroyed web contents.

Before this change, selecting "Close all incognito windows"
while Chrome was showing "You're leaving incognito mode"
warning dialog will cause a crash.

After this change, the crash is avoided.

BUG=705844
Review-Url: https://codereview.chromium.org/2778193003
Cr-Commit-Position: refs/heads/master@{#460574}
Committed: https://chromium.googlesource.com/chromium/src/+/6f0e189728f2cceb9534536cd175787da5f3c0e1

[please use gerrit instead, 2017-03-28 15:02:41]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[please use gerrit instead, 2017-03-28 15:02:45]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-03-28 15:03:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2017-03-28 15:04:08]

rouslan@chromium.org changed reviewers:
+ nyquist@chromium.org

[please use gerrit instead, 2017-03-28 15:04:09]

nyquist, ptal.

The change to AndroidPaymentApp.java fixes the bug in question. The change to
ChromeActivity.java is for the function that I introduced a while ago. I'm not
aware of a way to trigger webContents.isDestroyed() in there off of top of my
head, but I feel that it's better to be safe than sorry.

[commit-bot: I haz the power, 2017-03-28 15:48:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 15:48:06]

Dry run: This issue passed the CQ dry run.

[nyquist, 2017-03-29 20:43:15]

The code looks OK, but could you please expand the CL description?

Maybe you could have a paragraph each for these questions:
- What happened before this change?
- Why was that bad?
- How does this CL make it better?

And bonus points for also mentioning for example in which scenarios this would
typically fail, etc.

[please use gerrit instead, 2017-03-29 21:16:17]

Description was changed from

==========
Don't access destroyed web contents.

BUG=705844
==========

to

==========
Don't access destroyed web contents.

Before this change, selecting "Close all incognito windows"
while Chrome was showing "You're leaving incognito mode"
warning dialog will cause a crash.

After this change, the crash is avoided.

BUG=705844
==========

[nyquist, 2017-03-29 21:16:43]

lgtm

[please use gerrit instead, 2017-03-29 21:17:33]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2017-03-29 21:18:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 23:25:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490822253763580,
"parent_rev": "31472d1f58ffa076a5697e22aded98f2adde994a", "commit_rev":
"6f0e189728f2cceb9534536cd175787da5f3c0e1"}

[commit-bot: I haz the power, 2017-03-29 23:26:37]

Description was changed from

==========
Don't access destroyed web contents.

Before this change, selecting "Close all incognito windows"
while Chrome was showing "You're leaving incognito mode"
warning dialog will cause a crash.

After this change, the crash is avoided.

BUG=705844
==========

to

==========
Don't access destroyed web contents.

Before this change, selecting "Close all incognito windows"
while Chrome was showing "You're leaving incognito mode"
warning dialog will cause a crash.

After this change, the crash is avoided.

BUG=705844

Review-Url: https://codereview.chromium.org/2778193003
Cr-Commit-Position: refs/heads/master@{#460574}
Committed:
https://chromium.googlesource.com/chromium/src/+/6f0e189728f2cceb9534536cd175...
==========

[commit-bot: I haz the power, 2017-03-29 23:26:38]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6f0e189728f2cceb9534536cd175...