Make base::FilePath move constructor and assignment noexcept.

Make base::FilePath move constructor and assignment noexcept.

This should improve performance slightly when used in certain cases like a
std::vector.

Review-Url: https://codereview.chromium.org/2778183003
Cr-Commit-Position: refs/heads/master@{#460470}
Committed: https://chromium.googlesource.com/chromium/src/+/4e53ee167df2f069c380ad218e56d34772ec83e2

[brettw, 2017-03-28 23:22:46]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2017-03-28 23:23:12]

brettw@chromium.org changed reviewers:
+ jbroman@chromium.org

[commit-bot: I haz the power, 2017-03-28 23:23:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 23:42:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 23:42:11]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[jbroman, 2017-03-29 14:16:01]

Windows failure:

FAILED: obj/base/base/file_path.obj 
ninja -t msvc -e environment.x86 -- E:\b\c\goma_client/gomacc.exe
"E:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64_x86/cl.exe"
/nologo /showIncludes /FC @obj/base/base/file_path.obj.rsp /c
../../base/files/file_path.cc /Foobj/base/base/file_path.obj
/Fd"obj/base/base_cc.pdb"
e:\b\c\b\win\src\base\files\file_path.cc(194): error C2610: 'base::FilePath
&base::FilePath::operator =(base::FilePath &&) noexcept': is not a special
member function which can be defaulted
e:\b\c\b\win\src\base\files\file_path.cc(194): note: exception specification
does not match the implicitly declared specification.

[jbroman, 2017-03-29 14:18:45]

On 2017/03/29 at 14:16:01, jbroman wrote:
> Windows failure:
> 
> FAILED: obj/base/base/file_path.obj 
> ninja -t msvc -e environment.x86 -- E:\b\c\goma_client/gomacc.exe
"E:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64_x86/cl.exe"
/nologo /showIncludes /FC @obj/base/base/file_path.obj.rsp /c
../../base/files/file_path.cc /Foobj/base/base/file_path.obj
/Fd"obj/base/base_cc.pdb"
> e:\b\c\b\win\src\base\files\file_path.cc(194): error C2610: 'base::FilePath
&base::FilePath::operator =(base::FilePath &&) noexcept': is not a special
member function which can be defaulted
> e:\b\c\b\win\src\base\files\file_path.cc(194): note: exception specification
does not match the implicitly declared specification.

Android failure:

FAILED: obj/base/base/file_path.o 
/b/c/goma_client/gomacc
../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++
-MMD -MF obj/base/base/file_path.o.d -DV8_DEPRECATION_WARNINGS
-DDCHECK_ALWAYS_ON=1 -DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC -DDISABLE_NACL
-DSAFE_BROWSING_DB_REMOTE -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1
-DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -DANDROID -DHAVE_SYS_UIO_H
-DANDROID_NDK_VERSION=r12b -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS
-D_FORTIFY_SOURCE=2 -D__GNU_SOURCE=1 -DNDEBUG -DNVALGRIND
-DDYNAMIC_ANNOTATIONS_ENABLED=0 -DBASE_IMPLEMENTATION -I../.. -Igen
-Igen/base/base_jni_headers -Igen/base/base_jni_headers/base
-Igen/android_runtime_jni_headers/base
-I../../third_party/android_tools/ndk/sources/android/cpufeatures
-fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector
-Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__=
-funwind-tables -fPIC -pipe -ffunction-sections -fno-short-enums
-finline-limit=64 -march=armv7-a -mfloat-abi=softfp -mtune=generic-armv7-a
-fno-tree-sra -fno-caller-saves -mfpu=neon -mthumb -mthumb-interwork -Wall
-Werror -Wno-psabi -Wno-unused-local-typedefs -Wno-maybe-uninitialized
-Wno-missing-field-initializers -Wno-unused-parameter -fomit-frame-pointer
-gdwarf-3 -g1
--sysroot=../../third_party/android_tools/ndk/platforms/android-16/arch-arm
-fvisibility=hidden -O2 -fno-ident -fdata-sections -ffunction-sections
-fvisibility-inlines-hidden -std=gnu++11 -Wno-narrowing -fno-rtti
-isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include
-isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++abi/libcxxabi/include
-isystem../../third_party/android_tools/ndk/sources/android/support/include
-fno-exceptions -c ../../base/files/file_path.cc -o obj/base/base/file_path.o
../../base/files/file_path.cc:194:11: error: function 'base::FilePath&
base::FilePath::operator=(base::FilePath&&)' defaulted on its redeclaration with
an exception-specification that differs from the implicit declaration
'base::FilePath& base::FilePath::operator=(base::FilePath&&)'
 FilePath& FilePath::operator=(FilePath&& that) noexcept = default;
           ^

[brettw, 2017-03-29 15:01:37]

Just move constructor

[brettw, 2017-03-29 15:01:55]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 15:02:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2017-03-29 17:28:50]

lgtm

[brettw, 2017-03-29 17:51:00]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2017-03-29 17:51:03]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2017-03-29 17:51:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 18:41:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490809863054420,
"parent_rev": "60900cbcf95fb50ed89330e5d26d5f37f9b845ef", "commit_rev":
"bbb0da93d26f0d4c00d31f9af5c41f30846522b9"}

[commit-bot: I haz the power, 2017-03-29 18:47:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490809863054420,
"parent_rev": "02128266dda94d175c6e4070a7f67b6232d6ae03", "commit_rev":
"4e53ee167df2f069c380ad218e56d34772ec83e2"}

[commit-bot: I haz the power, 2017-03-29 18:48:19]

Description was changed from

==========
Make base::FilePath move constructor and assignment noexcept.

This should improve performance slightly when used in certain cases like a
std::vector.
==========

to

==========
Make base::FilePath move constructor and assignment noexcept.

This should improve performance slightly when used in certain cases like a
std::vector.

Review-Url: https://codereview.chromium.org/2778183003
Cr-Commit-Position: refs/heads/master@{#460470}
Committed:
https://chromium.googlesource.com/chromium/src/+/4e53ee167df2f069c380ad218e56...
==========

[commit-bot: I haz the power, 2017-03-29 18:48:20]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4e53ee167df2f069c380ad218e56...