Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2778183002: Fetch API: Remove expectation files of request.js (Closed)

Created:
3 years, 8 months ago by yiyix
Modified:
3 years, 8 months ago
Reviewers:
falken
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fetch API: Remove expectation files of request.js Fixes the "duplicate test names" error for tests in request.js, after which all test cases in request.js pass without warnings or errors. So the expectation files can be safely removed. BUG=624278 Review-Url: https://codereview.chromium.org/2778183002 Cr-Commit-Position: refs/heads/master@{#460257} Committed: https://chromium.googlesource.com/chromium/src/+/e589313cfc0a5f177668275af93feedb046f783f

Patch Set 1 #

Messages

Total messages: 21 (15 generated)
yiyix
@falken, could you please review this patch? Thank you very much.
3 years, 8 months ago (2017-03-29 01:06:31 UTC) #8
falken
lgtm It'd be a bit more explanatory if the CL description mentioned that this is ...
3 years, 8 months ago (2017-03-29 01:06:58 UTC) #9
falken
Also could add "Fetch API: " or something to the first line.
3 years, 8 months ago (2017-03-29 01:07:23 UTC) #10
yiyix
On 2017/03/29 01:07:23, falken wrote: > Also could add "Fetch API: " or something to ...
3 years, 8 months ago (2017-03-29 01:16:47 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778183002/1
3 years, 8 months ago (2017-03-29 01:17:56 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 01:23:43 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e589313cfc0a5f177668275af93f...

Powered by Google App Engine
This is Rietveld 408576698