Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Issue 2778163004: Restrict the amount of text shown in dialogs. (Closed)

Created:
3 years, 8 months ago by Avi (use Gerrit)
Modified:
3 years, 8 months ago
Reviewers:
nasko
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Restrict the amount of text shown in dialogs. BUG=702638 TEST=as in bug Review-Url: https://codereview.chromium.org/2778163004 Cr-Commit-Position: refs/heads/master@{#460274} Committed: https://chromium.googlesource.com/chromium/src/+/49bcdac7e28c672a3de1b11c70f4164b9582faa7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc View 2 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Avi (use Gerrit)
3 years, 8 months ago (2017-03-28 22:56:02 UTC) #6
nasko
Rubberstamp LGTM
3 years, 8 months ago (2017-03-28 23:56:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778163004/1
3 years, 8 months ago (2017-03-29 03:16:13 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 04:16:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/49bcdac7e28c672a3de1b11c70f4...

Powered by Google App Engine
This is Rietveld 408576698