Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2778133003: [turbofan] Add support for extending properties backing store. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for extending properties backing store. TurboFan didn't support transitioning stores that also need to grow the properties backing store so far. This CL adds support for re-allocating the properties backing store in-place, so these stores can participate properly in various optimizations like escape analysis and allocation folding. R=ishell@chromium.org BUG=v8:5267, chromium:708339 Review-Url: https://codereview.chromium.org/2778133003 Cr-Original-Commit-Position: refs/heads/master@{#44183} Committed: https://chromium.googlesource.com/v8/v8/+/88a7061a53ad200121f7ee2b2bdcc05d793de806 Review-Url: https://codereview.chromium.org/2778133003 Cr-Commit-Position: refs/heads/master@{#44499} Committed: https://chromium.googlesource.com/v8/v8/+/4faa4952fdd49eb2e75d2eac54dc17043793cb1d

Patch Set 1 #

Patch Set 2 : REBASE #

Patch Set 3 : REBASE #

Patch Set 4 : Fix invalid write barrier kind. Allocate can turn into old-space during allocation folding. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -8 lines) Patch
M src/compiler/access-info.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/js-native-context-specialization.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 2 3 2 chunks +66 lines, -4 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
Benedikt Meurer
3 years, 8 months ago (2017-03-28 07:11:41 UTC) #1
Benedikt Meurer
Hey Igor, Here's the support for inlining the properties backing store extension. It properly integrates ...
3 years, 8 months ago (2017-03-28 07:13:03 UTC) #4
Igor Sheludko
lgtm
3 years, 8 months ago (2017-03-28 09:13:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778133003/1
3 years, 8 months ago (2017-03-28 09:23:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/88a7061a53ad200121f7ee2b2bdcc05d793de806
3 years, 8 months ago (2017-03-28 09:24:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778133003/60001
3 years, 8 months ago (2017-04-08 17:56:06 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-08 18:45:36 UTC) #22
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/4faa4952fdd49eb2e75d2eac54dc1704379...

Powered by Google App Engine
This is Rietveld 408576698