Adding VisualConstraintsWithMetricsAndOptions()

Adding VisualConstraintsWithMetricsAndOptions()

Adding VisualConstraintsWithMetricsAndOptions() and VisualConstraintsWithMetrics().

BUG=

Review-Url: https://codereview.chromium.org/2778073002
Cr-Commit-Position: refs/heads/master@{#460347}
Committed: https://chromium.googlesource.com/chromium/src/+/69fd1b5798090316e9969c007aaf88cd5da6ef76

[jlebel, 2017-03-27 21:24:50]

jlebel@chromium.org changed reviewers:
+ marq@chromium.org

[jlebel, 2017-03-27 21:24:51]

Hello Mark,

Can you review this short patch to add helper functions?

Thanks,

[marq (ping after 24h), 2017-03-28 07:37:47]

lgtm

[lpromero, 2017-03-28 11:10:07]

lpromero@chromium.org changed reviewers:
+ lpromero@chromium.org

[lpromero, 2017-03-28 11:10:07]

https://codereview.chromium.org/2778073002/diff/1/ios/chrome/browser/ui/uikit...
File ios/chrome/browser/ui/uikit_ui_util.mm (right):

https://codereview.chromium.org/2778073002/diff/1/ios/chrome/browser/ui/uikit...
ios/chrome/browser/ui/uikit_ui_util.mm:601: [NSMutableArray
arrayWithCapacity:constraints.count * 3];
Question for marq: I don't understand the 3. Is it deterministic? A single
visual format string can output way more than 3 constraints.

[marq (ping after 24h), 2017-03-28 12:15:13]

https://codereview.chromium.org/2778073002/diff/1/ios/chrome/browser/ui/uikit...
File ios/chrome/browser/ui/uikit_ui_util.mm (right):

https://codereview.chromium.org/2778073002/diff/1/ios/chrome/browser/ui/uikit...
ios/chrome/browser/ui/uikit_ui_util.mm:601: [NSMutableArray
arrayWithCapacity:constraints.count * 3];
On 2017/03/28 11:10:07, lpromero wrote:
> Question for marq: I don't understand the 3. Is it deterministic? A single
> visual format string can output way more than 3 constraints.

No, it was an estimate. It should probably be documented or just removed, since
I don't know at what point the capacity estimates become optimizations.

https://codereview.chromium.org/2778073002/diff/1/ios/chrome/browser/ui/uikit...
ios/chrome/browser/ui/uikit_ui_util.mm:611: return layoutConstraints;
Missed this: this should return [layoutConstrains copy], so it returns an
immutable array without keeping the mutable array overhead around for no reason.

[jlebel, 2017-03-28 13:05:52]

Patchset #2 (id:20001) has been deleted

[jlebel, 2017-03-28 13:24:37]

Patchset #2 (id:40001) has been deleted

[jlebel, 2017-03-28 16:31:19]

Patchset #2 (id:60001) has been deleted

[jlebel, 2017-03-29 01:05:11]

Patchset #2 (id:80001) has been deleted

[jlebel, 2017-03-29 10:46:57]

The CQ bit was checked by jlebel@chromium.org

[jlebel, 2017-03-29 10:46:58]

The patchset sent to the CQ was uploaded after l-g-t-m from marq@chromium.org
Link to the patchset: https://codereview.chromium.org/2778073002/#ps100001
(title: "Merge + fix")

[jlebel, 2017-03-29 10:47:04]

The CQ bit was unchecked by jlebel@chromium.org

[jlebel, 2017-03-29 10:47:17]

Thanks,

https://codereview.chromium.org/2778073002/diff/1/ios/chrome/browser/ui/uikit...
File ios/chrome/browser/ui/uikit_ui_util.mm (right):

https://codereview.chromium.org/2778073002/diff/1/ios/chrome/browser/ui/uikit...
ios/chrome/browser/ui/uikit_ui_util.mm:601: [NSMutableArray
arrayWithCapacity:constraints.count * 3];
On 2017/03/28 12:15:13, marq wrote:
> On 2017/03/28 11:10:07, lpromero wrote:
> > Question for marq: I don't understand the 3. Is it deterministic? A single
> > visual format string can output way more than 3 constraints.
> 
> No, it was an estimate. It should probably be documented or just removed,
since
> I don't know at what point the capacity estimates become optimizations.

Removed as talk offline.

https://codereview.chromium.org/2778073002/diff/1/ios/chrome/browser/ui/uikit...
ios/chrome/browser/ui/uikit_ui_util.mm:611: return layoutConstraints;
On 2017/03/28 12:15:13, marq wrote:
> Missed this: this should return [layoutConstrains copy], so it returns an
> immutable array without keeping the mutable array overhead around for no
reason.

Done.

[jlebel, 2017-03-29 10:47:20]

The CQ bit was checked by jlebel@chromium.org

[commit-bot: I haz the power, 2017-03-29 10:47:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 11:03:40]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1490784440943340,
"parent_rev": "48912f58556f8610cc93c4396d515ca281162166", "commit_rev":
"69fd1b5798090316e9969c007aaf88cd5da6ef76"}

[commit-bot: I haz the power, 2017-03-29 11:04:25]

Description was changed from

==========
Adding VisualConstraintsWithMetricsAndOptions()

Adding VisualConstraintsWithMetricsAndOptions() and
VisualConstraintsWithMetrics().

BUG=
==========

to

==========
Adding VisualConstraintsWithMetricsAndOptions()

Adding VisualConstraintsWithMetricsAndOptions() and
VisualConstraintsWithMetrics().

BUG=

Review-Url: https://codereview.chromium.org/2778073002
Cr-Commit-Position: refs/heads/master@{#460347}
Committed:
https://chromium.googlesource.com/chromium/src/+/69fd1b5798090316e9969c007aaf...
==========

[commit-bot: I haz the power, 2017-03-29 11:04:27]

Committed patchset #2 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/69fd1b5798090316e9969c007aaf...