Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: third_party/libaddressinput/BUILD.gn

Issue 2778053003: Revert of Enable -Wdeprecated-register. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/ColorData.gperf ('k') | third_party/mesa/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libaddressinput/BUILD.gn
diff --git a/third_party/libaddressinput/BUILD.gn b/third_party/libaddressinput/BUILD.gn
index 6468e4fc9abf70a395c2b9e0796df045a5f81e31..e4e5381cb150297f335bd930291ec7fcb7e4e9be 100644
--- a/third_party/libaddressinput/BUILD.gn
+++ b/third_party/libaddressinput/BUILD.gn
@@ -6,14 +6,9 @@
import("//build/config/locales.gni")
import("//tools/grit/grit_rule.gni")
-config("internal_config") {
+config("no-newline-eof-warning") {
if (is_clang) {
- cflags = [
- "-Wno-newline-eof",
-
- # md5.cc uses "register". TODO(thakis): Fix.
- "-Wno-deprecated-register",
- ]
+ cflags = [ "-Wno-newline-eof" ]
}
}
@@ -31,7 +26,7 @@
outputs += [ "address_input_strings_$locale.pak" ]
}
- configs = [ ":internal_config" ]
+ configs = [ ":no-newline-eof-warning" ]
}
config("libaddressinput_config") {
@@ -69,7 +64,7 @@
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [
- ":internal_config",
+ ":no-newline-eof-warning",
"//build/config/compiler:no_chromium_code",
]
@@ -117,10 +112,7 @@
]
configs -= [ "//build/config/compiler:chromium_code" ]
- configs += [
- ":internal_config",
- "//build/config/compiler:no_chromium_code",
- ]
+ configs += [ "//build/config/compiler:no_chromium_code" ]
public_configs = [ ":libaddressinput_config" ]
@@ -146,10 +138,7 @@
]
configs -= [ "//build/config/compiler:chromium_code" ]
- configs += [
- ":internal_config",
- "//build/config/compiler:no_chromium_code",
- ]
+ configs += [ "//build/config/compiler:no_chromium_code" ]
defines = [ "TEST_DATA_DIR=\"src/third_party/libaddressinput/src/testdata\"" ]
@@ -215,10 +204,7 @@
}
configs -= [ "//build/config/compiler:chromium_code" ]
- configs += [
- ":internal_config",
- "//build/config/compiler:no_chromium_code",
- ]
+ configs += [ "//build/config/compiler:no_chromium_code" ]
include_dirs = [ "src/cpp/src" ]
« no previous file with comments | « third_party/WebKit/Source/platform/ColorData.gperf ('k') | third_party/mesa/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698