Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 2778043004: Factor out StringAppendF into spdy/platform/. (Closed)

Created:
3 years, 8 months ago by Bence
Modified:
3 years, 8 months ago
Reviewers:
diannahu, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Factor out StringAppendF into spdy/platform/. This is a follow-up to https://crrev.com/2774673002. This CL lands server change 151348843 by bnc. BUG=488484 Review-Url: https://codereview.chromium.org/2778043004 Cr-Commit-Position: refs/heads/master@{#460487} Committed: https://chromium.googlesource.com/chromium/src/+/50cdd3373b5fd13e9f4e1354d14e3f1c782e4b35

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -7 lines) Patch
M net/spdy/platform/api/spdy_string_utils.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/spdy/platform/api/spdy_string_utils_test.cc View 3 chunks +19 lines, -3 lines 0 comments Download
M net/spdy/platform/impl/spdy_string_utils_impl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/spdy/spdy_alt_svc_wire_format.cc View 3 chunks +4 lines, -4 lines 3 comments Download

Messages

Total messages: 18 (9 generated)
Bence
diannahu: PTAL. Thank you.
3 years, 8 months ago (2017-03-29 13:16:10 UTC) #6
diannahu
lgtm LGTM with minor question. https://codereview.chromium.org/2778043004/diff/1/net/spdy/spdy_alt_svc_wire_format.cc File net/spdy/spdy_alt_svc_wire_format.cc (right): https://codereview.chromium.org/2778043004/diff/1/net/spdy/spdy_alt_svc_wire_format.cc#newcode12 net/spdy/spdy_alt_svc_wire_format.cc:12: #include "base/strings/string_util.h" Can this ...
3 years, 8 months ago (2017-03-29 15:42:57 UTC) #7
Bence
xunjieli: Please rubber stamp. diannahu: Thank you very much for the review. https://codereview.chromium.org/2778043004/diff/1/net/spdy/spdy_alt_svc_wire_format.cc File net/spdy/spdy_alt_svc_wire_format.cc ...
3 years, 8 months ago (2017-03-29 16:56:19 UTC) #9
diannahu
lgtm
3 years, 8 months ago (2017-03-29 17:25:52 UTC) #10
xunjieli
https://codereview.chromium.org/2778043004/diff/1/net/spdy/spdy_alt_svc_wire_format.cc File net/spdy/spdy_alt_svc_wire_format.cc (right): https://codereview.chromium.org/2778043004/diff/1/net/spdy/spdy_alt_svc_wire_format.cc#newcode12 net/spdy/spdy_alt_svc_wire_format.cc:12: #include "base/strings/string_util.h" On 2017/03/29 16:56:18, Bence wrote: > On ...
3 years, 8 months ago (2017-03-29 17:43:49 UTC) #11
Bence
On 2017/03/29 17:43:49, xunjieli wrote: > https://codereview.chromium.org/2778043004/diff/1/net/spdy/spdy_alt_svc_wire_format.cc > File net/spdy/spdy_alt_svc_wire_format.cc (right): > > https://codereview.chromium.org/2778043004/diff/1/net/spdy/spdy_alt_svc_wire_format.cc#newcode12 > ...
3 years, 8 months ago (2017-03-29 18:28:22 UTC) #12
xunjieli
On 2017/03/29 18:28:22, Bence wrote: > On 2017/03/29 17:43:49, xunjieli wrote: > > > https://codereview.chromium.org/2778043004/diff/1/net/spdy/spdy_alt_svc_wire_format.cc ...
3 years, 8 months ago (2017-03-29 18:37:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778043004/1
3 years, 8 months ago (2017-03-29 19:08:20 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 19:26:45 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/50cdd3373b5fd13e9f4e1354d14e...

Powered by Google App Engine
This is Rietveld 408576698