Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1533)

Issue 2778043002: Rename WebSiteSettingsPopupViewBrowserTest to PageInfoPopupViewBrowserTest. (Closed)

Created:
3 years, 9 months ago by lgarron
Modified:
3 years, 9 months ago
Reviewers:
estark
CC:
chromium-reviews, lgarron+watch_chromium.org, raymes+watch_chromium.org, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename WebSiteSettingsPopupViewBrowserTest to PageInfoPopupViewBrowserTest. BUG=705627 Review-Url: https://codereview.chromium.org/2778043002 Cr-Commit-Position: refs/heads/master@{#459893} Committed: https://chromium.googlesource.com/chromium/src/+/625dec950fc94b1678646d4d5ef19b76c49c96db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M chrome/browser/ui/views/page_info/page_info_popup_view_interactive_uitest.cc View 4 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
lgarron
estark@, could you review? I missed this in https://crrev.com/2754383004 (Rename WebsiteSettings code to PageInfo.) because ...
3 years, 9 months ago (2017-03-27 20:06:21 UTC) #2
estark
lgtm
3 years, 9 months ago (2017-03-27 20:50:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778043002/1
3 years, 9 months ago (2017-03-27 20:51:59 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 21:54:31 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/625dec950fc94b1678646d4d5ef1...

Powered by Google App Engine
This is Rietveld 408576698