Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2778023002: Fix class reference in page_info.xml (Closed)

Created:
3 years, 9 months ago by lgarron
Modified:
3 years, 9 months ago
Reviewers:
Ted C
CC:
agrieve+watch_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix class reference in page_info.xml BUG=705355 TEST=Visit https://google.com, click the lock icon in the URL bar, and check that the Page Info popup appears (it contains a heading stating "Secure connection"). Review-Url: https://codereview.chromium.org/2778023002 Cr-Commit-Position: refs/heads/master@{#459869} Committed: https://chromium.googlesource.com/chromium/src/+/bdab57c60efc34aedfb2055b1296008ba9015414

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/res/layout/page_info.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
lgarron
tedchoc@, could you review?
3 years, 9 months ago (2017-03-27 18:59:00 UTC) #2
Ted C
lgtm
3 years, 9 months ago (2017-03-27 19:49:24 UTC) #5
lgarron
On 2017/03/27 at 19:49:24, tedchoc wrote: > lgtm Once this lands and un-blocks dev, is ...
3 years, 9 months ago (2017-03-27 19:50:58 UTC) #6
Ted C
On 2017/03/27 19:50:58, lgarron wrote: > On 2017/03/27 at 19:49:24, tedchoc wrote: > > lgtm ...
3 years, 9 months ago (2017-03-27 20:17:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778023002/1
3 years, 9 months ago (2017-03-27 20:25:21 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 20:49:11 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bdab57c60efc34aedfb2055b1296...

Powered by Google App Engine
This is Rietveld 408576698