Add jkarlin@ to net/OWNERS file

Add jkarlin@ to net/OWNERS file

jkarlin@ committed more than 3k lines to net/, particular in the area of
cache.

Review-Url: https://codereview.chromium.org/2778003002
Cr-Commit-Position: refs/heads/master@{#459861}
Committed: https://chromium.googlesource.com/chromium/src/+/3083836246aaa08375a7538c869a91cd37a209a3

[xunjieli, 2017-03-27 18:40:58]

xunjieli@chromium.org changed reviewers:
+ asanka@chromium.org, mmenke@chromium.org

[xunjieli, 2017-03-27 18:40:59]

Is there a guideline for adding net/ OWNERS?

[mmenke, 2017-03-27 18:48:57]

Description was changed from

==========
Add jkarlin@ to net/OWNERS file

jkarlin@ landed and reviewed a non-trivial number of CLs in net/ cache.
==========

to

==========
Add jkarlin@ to net/OWNERS file

jkarlin@ landed and reviewed a non-trivial number of CLs in net/ cache.
==========

[mmenke, 2017-03-27 18:48:57]

mmenke@chromium.org changed reviewers:
+ jkarlin@chromium.org

[asanka, 2017-03-27 18:50:30]

The Chrome-wide OWNERS guidlines are at
https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#...

I'll yield to Matt on evaluating that.

https://codereview.chromium.org/2778003002/diff/1/net/OWNERS
File net/OWNERS (right):

https://codereview.chromium.org/2778003002/diff/1/net/OWNERS#newcode16
net/OWNERS:16: jkarlin@chromium.org
This section is supposed to be sorted. I believe Julia's entry just wasn't moved
to where it should be after the username changed.

[mmenke, 2017-03-27 18:52:22]

On 2017/03/27 18:40:59, xunjieli wrote:
> Is there a guideline for adding net/ OWNERS?

[+jkarlin]  There's not really a guideline.  We generally try and add people at
the intersection of when we're thinking about it and they have over ~3000 or so
(I think?) lines added to net/.  I checked jkarlin's commits when I added you
and elly, and again when I added bnc, I believe, and he was below that.

Doing just a brain-dead "git log -p --source --author=jkarlin@chromium.org net/"
shows 3,300 lines modified/added, over ~3 years.  I'm fine with adding him,
unless he objects.

[xunjieli, 2017-03-27 18:57:11]

Description was changed from

==========
Add jkarlin@ to net/OWNERS file

jkarlin@ landed and reviewed a non-trivial number of CLs in net/ cache.
==========

to

==========
Add jkarlin@ to net/OWNERS file

jkarlin@ committed more than 3k lines to net/ particular in the area of
cache.
==========

[xunjieli, 2017-03-27 18:57:39]

Description was changed from

==========
Add jkarlin@ to net/OWNERS file

jkarlin@ committed more than 3k lines to net/ particular in the area of
cache.
==========

to

==========
Add jkarlin@ to net/OWNERS file

jkarlin@ committed more than 3k lines to net/, particular in the area of
cache.
==========

[xunjieli, 2017-03-27 18:59:41]

Thanks Matt and Asanka. Good to know about the criteria. I am comfortable with
Josh reviewing cache-related changes.

https://codereview.chromium.org/2778003002/diff/1/net/OWNERS
File net/OWNERS (right):

https://codereview.chromium.org/2778003002/diff/1/net/OWNERS#newcode16
net/OWNERS:16: jkarlin@chromium.org
On 2017/03/27 18:50:30, asanka wrote:
> This section is supposed to be sorted. I believe Julia's entry just wasn't
moved
> to where it should be after the username changed.

Oops. Done.

[jkarlin, 2017-03-27 19:01:04]

Works for me. For now I'd stick to cache related CLs as I'm trying to ramp up in
non-net/ areas at the moment.

[mmenke, 2017-03-27 19:02:59]

On 2017/03/27 19:01:04, jkarlin wrote:
> Works for me. For now I'd stick to cache related CLs as I'm trying to ramp up
in
> non-net/ areas at the moment.

It's certainly fine to punt CLs to people who know an area better (While we've
repeatedly talked about per-directory owners, we've taken no steps in that
direction).

LGTM!

[xunjieli, 2017-03-27 19:06:38]

The CQ bit was checked by xunjieli@chromium.org

[commit-bot: I haz the power, 2017-03-27 19:07:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 20:00:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490641598799800,
"parent_rev": "774a505798df8953c266adc440dbd6304d75fa32", "commit_rev":
"3083836246aaa08375a7538c869a91cd37a209a3"}

[commit-bot: I haz the power, 2017-03-27 20:01:35]

Description was changed from

==========
Add jkarlin@ to net/OWNERS file

jkarlin@ committed more than 3k lines to net/, particular in the area of
cache.
==========

to

==========
Add jkarlin@ to net/OWNERS file

jkarlin@ committed more than 3k lines to net/, particular in the area of
cache.

Review-Url: https://codereview.chromium.org/2778003002
Cr-Commit-Position: refs/heads/master@{#459861}
Committed:
https://chromium.googlesource.com/chromium/src/+/3083836246aaa08375a7538c869a...
==========

[commit-bot: I haz the power, 2017-03-27 20:01:36]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3083836246aaa08375a7538c869a...