Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Issue 2777993002: [sync] Add regression test for TabContentsSyncedTabDelegate crash (Closed)

Created:
3 years, 8 months ago by Patrick Noland
Modified:
3 years, 8 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[sync] Add regression test for TabContentsSyncedTabDelegate crash Add a test that accesses an invalid navigation index, expecting no crash to occur and the default value to be returned. BUG=704871 R=zea@chromium.org Review-Url: https://codereview.chromium.org/2777993002 Cr-Commit-Position: refs/heads/master@{#459926} Committed: https://chromium.googlesource.com/chromium/src/+/8c74bf60202e99c7f8fcf765db8cd601693317b1

Patch Set 1 : [sync] Add regression test for TabContentsSyncedTabDelegate crash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -0 lines) Patch
A chrome/browser/ui/sync/tab_contents_synced_tab_delegate_unittest.cc View 1 chunk +47 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
Patrick Noland
Nicolas, PTAL
3 years, 8 months ago (2017-03-27 19:35:26 UTC) #8
Nicolas Zea
lgtm
3 years, 8 months ago (2017-03-27 19:58:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777993002/20001
3 years, 8 months ago (2017-03-27 20:32:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777993002/20001
3 years, 8 months ago (2017-03-27 20:33:56 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-03-27 23:11:59 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8c74bf60202e99c7f8fcf765db8c...

Powered by Google App Engine
This is Rietveld 408576698