Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2777983002: Convert Analyser tests to use new Audit. (Closed)

Created:
3 years, 9 months ago by Raymond Toy
Modified:
3 years, 8 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Analyser tests to use new Audit. Manually converted these tests to use new Audit from old Audit. BUG=704967 TEST=Analyser/realtimeanalyser-byte-data.html Analyser/realtimeanalyser-downmix.html Analyser/realtimeanalyser-fftsize-reset.html Analyser/realtimeanalyser-float-data.html Analyser/realtimeanalyser-freq-data.html Analyser/realtimeanalyser-freq-data-smoothing.html Analyser/realtimeanalyser-multiple-calls.html Analyser/realtimeanalyser-zero.html Review-Url: https://codereview.chromium.org/2777983002 Cr-Commit-Position: refs/heads/master@{#460575} Committed: https://chromium.googlesource.com/chromium/src/+/94161a5070865ff5d84dc45417786758ed372fa6

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : Remove console.logs #

Messages

Total messages: 13 (6 generated)
Raymond Toy
PTAL
3 years, 8 months ago (2017-03-29 16:06:16 UTC) #3
hongchan
On 2017/03/29 16:06:16, Raymond Toy wrote: > PTAL Is this the final stage of conversion? ...
3 years, 8 months ago (2017-03-29 16:54:52 UTC) #4
Raymond Toy
On 2017/03/29 16:54:52, hongchan wrote: > On 2017/03/29 16:06:16, Raymond Toy wrote: > > PTAL ...
3 years, 8 months ago (2017-03-29 16:56:48 UTC) #5
hongchan
lgtm with nit https://codereview.chromium.org/2777983002/diff/20001/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-multiple-calls.html File third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-multiple-calls.html (right): https://codereview.chromium.org/2777983002/diff/20001/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-multiple-calls.html#newcode64 third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-multiple-calls.html:64: console.log(f2); Remove all the console.logs.
3 years, 8 months ago (2017-03-29 21:07:02 UTC) #6
Raymond Toy
https://codereview.chromium.org/2777983002/diff/20001/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-multiple-calls.html File third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-multiple-calls.html (right): https://codereview.chromium.org/2777983002/diff/20001/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-multiple-calls.html#newcode64 third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-multiple-calls.html:64: console.log(f2); On 2017/03/29 21:07:02, hongchan wrote: > Remove all ...
3 years, 8 months ago (2017-03-29 21:44:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777983002/40001
3 years, 8 months ago (2017-03-29 21:45:15 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 23:28:18 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/94161a5070865ff5d84dc4541778...

Powered by Google App Engine
This is Rietveld 408576698