Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: third_party/WebKit/Source/modules/fetch/Response.cpp

Issue 2777943005: [Bindings] Move and remove some private symbols from V8HiddenValue (Closed)
Patch Set: Fix test failures Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/Response.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/Response.cpp b/third_party/WebKit/Source/modules/fetch/Response.cpp
index d5319f453f05869de885768408521d50bf6970f7..204022b10170330c8eb623ebd17d04dec671eae7 100644
--- a/third_party/WebKit/Source/modules/fetch/Response.cpp
+++ b/third_party/WebKit/Source/modules/fetch/Response.cpp
@@ -13,7 +13,7 @@
#include "bindings/core/v8/V8Binding.h"
#include "bindings/core/v8/V8Blob.h"
#include "bindings/core/v8/V8FormData.h"
-#include "bindings/core/v8/V8HiddenValue.h"
+#include "bindings/core/v8/V8PrivateProperty.h"
#include "bindings/core/v8/V8URLSearchParams.h"
#include "bindings/modules/v8/ByteStringSequenceSequenceOrDictionaryOrHeaders.h"
#include "core/dom/DOMArrayBuffer.h"
@@ -455,9 +455,8 @@ void Response::refreshBody(ScriptState* scriptState) {
return;
}
DCHECK(response->IsObject());
- V8HiddenValue::setHiddenValue(
- scriptState, response.As<v8::Object>(),
- V8HiddenValue::internalBodyBuffer(scriptState->isolate()), bodyBuffer);
+ V8PrivateProperty::getInternalBodyBuffer(scriptState->isolate())
+ .set(response.As<v8::Object>(), bodyBuffer);
}
DEFINE_TRACE(Response) {

Powered by Google App Engine
This is Rietveld 408576698